diff options
| author | bradnelson@google.com <bradnelson@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-19 23:24:37 +0000 |
|---|---|---|
| committer | bradnelson@google.com <bradnelson@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-19 23:24:37 +0000 |
| commit | 5e0a917feb3abdc18eac7951f178be5b9458a8d0 (patch) | |
| tree | 8a907ca0a49e81898f5e80df1d6a757c1b016276 /chrome/chrome_exe.gypi | |
| parent | 6fa8f9125365e6309644f34c2b813ef25b20c1c8 (diff) | |
| download | chromium_src-5e0a917feb3abdc18eac7951f178be5b9458a8d0.zip chromium_src-5e0a917feb3abdc18eac7951f178be5b9458a8d0.tar.gz chromium_src-5e0a917feb3abdc18eac7951f178be5b9458a8d0.tar.bz2 | |
Generating separate version resources for:
chrome.dll
chrome.exe
nacl64.dll
nacl64.exe
BUG=http://code.google.com/p/chromium/issues/detail?id=65350
TEST=None
R=cpu@chromium.org
Review URL: http://codereview.chromium.org/7390037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93124 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_exe.gypi')
| -rw-r--r-- | chrome/chrome_exe.gypi | 51 |
1 files changed, 9 insertions, 42 deletions
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index 84810ee..8f0a481 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -45,13 +45,6 @@ }, 'conditions': [ ['OS=="win"', { - 'sources': [ - 'app/chrome_exe.rc', - 'app/chrome_exe_version.rc.version', - ], - 'include_dirs': [ - '<(SHARED_INTERMEDIATE_DIR)/chrome', - ], # TODO(scottbyer): This is a temporary workaround. The right fix # is to change the output file to be in $(IntDir) for this project # and the .dll project and use the hardlink script to link it back @@ -83,41 +76,6 @@ }, 'actions': [ { - 'action_name': 'version', - 'variables': { - 'template_input_path': 'app/chrome_exe_version.rc.version', - }, - 'conditions': [ - [ 'branding == "Chrome"', { - 'variables': { - 'branding_path': 'app/theme/google_chrome/BRANDING', - }, - }, { # else branding!="Chrome" - 'variables': { - 'branding_path': 'app/theme/chromium/BRANDING', - }, - }], - ], - 'inputs': [ - '<(template_input_path)', - '<(version_path)', - '<(branding_path)', - ], - 'outputs': [ - '<(SHARED_INTERMEDIATE_DIR)/chrome/chrome_exe_version.rc', - ], - 'action': [ - 'python', - '<(version_py_path)', - '-f', '<(version_path)', - '-f', '<(branding_path)', - '<(template_input_path)', - '<@(_outputs)', - ], - 'process_outputs_as_sources': 1, - 'message': 'Generating version information in <(_outputs)' - }, - { 'action_name': 'first_run', 'inputs': [ 'app/FirstRun', @@ -465,6 +423,7 @@ }], ['OS=="win"', { 'dependencies': [ + 'chrome_version_resources', 'installer_util', 'installer_util_strings', '../base/base.gyp:base', @@ -474,6 +433,10 @@ 'app/locales/locales.gyp:*', 'app/policy/cloud_policy_codegen.gyp:policy', ], + 'sources': [ + 'app/chrome_exe.rc', + '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_exe_version.rc', + ], 'msvs_settings': { 'VCLinkerTool': { 'ImportLibrary': '$(OutDir)\\lib\\chrome_exe.lib', @@ -498,6 +461,7 @@ # On Windows make sure we've built Win64 version of chrome_dll, # which contains all of the library code with Chromium # functionality. + 'chrome_version_resources', 'chrome_dll_nacl_win64', 'common_constants_win64', 'installer_util_nacl_win64', @@ -514,6 +478,9 @@ 'include_dirs': [ '<(SHARED_INTERMEDIATE_DIR)/chrome', ], + 'sources': [ + '<(SHARED_INTERMEDIATE_DIR)/chrome_version/nacl64_exe_version.rc', + ], 'msvs_settings': { 'VCLinkerTool': { 'ImportLibrary': '$(OutDir)\\lib\\nacl64_exe.lib', |