diff options
| author | robertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 19:47:56 +0000 |
|---|---|---|
| committer | robertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 19:47:56 +0000 |
| commit | a3bb1a6c553b17964e4e8ee9041b7dff7191364e (patch) | |
| tree | 855480c56d0e96e29911001d76521ed6c6c3ab66 /chrome/chrome_installer.gypi | |
| parent | 83c86b6790ca8f58c910d7f68ae257a34b9a3206 (diff) | |
| download | chromium_src-a3bb1a6c553b17964e4e8ee9041b7dff7191364e.zip chromium_src-a3bb1a6c553b17964e4e8ee9041b7dff7191364e.tar.gz chromium_src-a3bb1a6c553b17964e4e8ee9041b7dff7191364e.tar.bz2 | |
Refactor out of install.cc the set of functions that operate on a work item list for better testability.
Write preliminary test framework for testing these functions.
BUG=61609
TEST=setup_unittests.exe
Review URL: http://codereview.chromium.org/6153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71473 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_installer.gypi')
| -rw-r--r-- | chrome/chrome_installer.gypi | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi index 1433ec5..9db6089 100644 --- a/chrome/chrome_installer.gypi +++ b/chrome/chrome_installer.gypi @@ -208,6 +208,8 @@ 'installer/setup/chrome_frame_ready_mode.h', 'installer/setup/install.cc', 'installer/setup/install.h', + 'installer/setup/install_worker.cc', + 'installer/setup/install_worker.h', 'installer/setup/setup_main.cc', 'installer/setup/setup.ico', 'installer/setup/setup.rc', @@ -311,13 +313,22 @@ '<(DEPTH)/base/base.gyp:base_i18n', '<(DEPTH)/base/base.gyp:test_support_base', '<(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl', + '<(DEPTH)/testing/gmock.gyp:gmock', '<(DEPTH)/testing/gtest.gyp:gtest', ], 'include_dirs': [ '<(DEPTH)', ], + # TODO(robertshield): Move the items marked with "Move to lib" + # below into a separate lib and then link both setup.exe and + # setup_unittests.exe against that. 'sources': [ + 'installer/setup/install_worker.cc', # Move to lib + 'installer/setup/install_worker.h', # Move to lib + 'installer/setup/install_worker_unittest.cc', 'installer/setup/run_all_unittests.cc', + 'installer/setup/setup_constants.cc', # Move to lib + 'installer/setup/setup_constants.h', # Move to lib 'installer/setup/setup_util.cc', 'installer/setup/setup_util_unittest.cc', ], |