diff options
| author | brettw <brettw@chromium.org> | 2015-10-07 10:18:15 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-07 17:22:58 +0000 |
| commit | f986f9572c792346194055784b9237820ffce52b (patch) | |
| tree | 5defcb5710ffb7bcfb720ed3fca199257f30b579 /chrome/chrome_installer.gypi | |
| parent | cc2f0758c4998db4b2fe2c59aa12aabb2eddc554 (diff) | |
| download | chromium_src-f986f9572c792346194055784b9237820ffce52b.zip chromium_src-f986f9572c792346194055784b9237820ffce52b.tar.gz chromium_src-f986f9572c792346194055784b9237820ffce52b.tar.bz2 | |
Add GCAPI to the GN build.
GCAPI is a Windows-specific API for distributors of Chrome.
This adds all chrome/installer targets to "gn check" and fixes many associated issues. The result codes targets are also added to "gn check" to make sure people don't accidentally add stuff to those headers.
Rather than add a disable for the size_t to int warning for this target, I just fixed the warning and removed the disable flag from GYP.
Merged //chrome/common:result_codes into //chrome/common:constants. This is basically a constant and everybody that needed the result codes already depended on the constants target.
Fix google_update build file. The midl template already did everything this file was trying to do. I clarified the template documentation a bit.
BUG=539428
Review URL: https://codereview.chromium.org/1388943004
Cr-Commit-Position: refs/heads/master@{#352869}
Diffstat (limited to 'chrome/chrome_installer.gypi')
| -rw-r--r-- | chrome/chrome_installer.gypi | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi index f448ad2..b7b6a3c 100644 --- a/chrome/chrome_installer.gypi +++ b/chrome/chrome_installer.gypi @@ -12,6 +12,7 @@ ['OS=="win"', { 'targets': [ { + # GN version: //chrome/installer/gcapi 'target_name': 'gcapi_dll', 'type': 'loadable_module', 'dependencies': [ @@ -26,6 +27,7 @@ ], }, { + # GN version: //chrome/installer/gcapi:lib 'target_name': 'gcapi_lib', 'type': 'static_library', 'dependencies': [ @@ -46,10 +48,9 @@ 'installer/gcapi/gcapi_reactivation.cc', 'installer/gcapi/gcapi_reactivation.h', ], - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - 'msvs_disabled_warnings': [ 4267, ], }, { + # GN version: //chrome/installer/gcapi:gcapi_test 'target_name': 'gcapi_test', 'type': 'executable', 'dependencies': [ |