diff options
| author | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-02 10:02:26 +0000 |
|---|---|---|
| committer | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-02 10:02:26 +0000 |
| commit | bbffa669691c4d2f9f1ab8f95226171be7b2dd04 (patch) | |
| tree | 0336c36be3524514fe5ab0f2d7341a6ae270877d /chrome/chrome_tests.gypi | |
| parent | 4f4c43ca4eed4bff261f6e4ff760a02455ef50aa (diff) | |
| download | chromium_src-bbffa669691c4d2f9f1ab8f95226171be7b2dd04.zip chromium_src-bbffa669691c4d2f9f1ab8f95226171be7b2dd04.tar.gz chromium_src-bbffa669691c4d2f9f1ab8f95226171be7b2dd04.tar.bz2 | |
The first step towards supporting the Hungarian spell-checking dictionary.
This change fixes a couple of problems needed for using a Hungarian dictionary in Chrome.
1. Use TrimWhitespace() in TrimLine()
Sorry, this is caused by my mistake that used TrimWhiteSpaceUTF8() without checking it deeply.
2. Replace morphing rules with compound rules.
it seems existing Hungarian dictionaries use (language-specific) morphing rules to handle words that have both prefixes and suffixes, e.g. "legjobb" (best). It is better to replace such (language-dependent) morphing rules with (language-independent) compound rules to avoid language-specific issues. (As far as I tested, this change fixes many quality problems caused by Hungarian compounds.)
This change also adds simple tests for our dictionary converter.
BUG=15558
TEST=unit_test --gtest_filter=ConvertDictTest*
Review URL: http://codereview.chromium.org/553087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37816 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rwxr-xr-x | chrome/chrome_tests.gypi | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 3b8f6c0..5738f3e 100755 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -874,6 +874,7 @@ 'test/test_notification_tracker.h', 'test/v8_unit_test.cc', 'test/v8_unit_test.h', + 'tools/convert_dict/convert_dict_unittest.cc', '../third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/compact_lang_det_unittest_small.cc', ], 'conditions': [ @@ -952,6 +953,7 @@ 'browser/views/bookmark_context_menu_test.cc', 'browser/gtk/go_button_gtk_unittest.cc', 'browser/gtk/tabs/tab_renderer_gtk_unittest.cc', + 'tools/convert_dict/convert_dict_unittest.cc', '../third_party/hunspell/google/hunspell_tests.cc', ], # TODO(mark): We really want this for all non-static library targets, |