diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-16 16:50:49 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-16 16:50:49 +0000 |
| commit | 5f3dc83c13bd6d7ffe0e84af3c260e610fe989ca (patch) | |
| tree | 15223975212ccbeeec859b35ef8365a75670838a /chrome/chrome_tests.gypi | |
| parent | 1dbaada05d7d6826d2da40fe7339bc10663d0db0 (diff) | |
| download | chromium_src-5f3dc83c13bd6d7ffe0e84af3c260e610fe989ca.zip chromium_src-5f3dc83c13bd6d7ffe0e84af3c260e610fe989ca.tar.gz chromium_src-5f3dc83c13bd6d7ffe0e84af3c260e610fe989ca.tar.bz2 | |
Fixes bug in bookmark bar view if profile changed. If the profile
changed we didn't remove the old buttons, which meant when you clicked
on a button it might be past the bounds of the model. I don't think we
ever do this, but it's the only thing I could see that could cause the
crash.
Once I've nailed this down I'll nuke the CHECKs.
BUG=44642
TEST=none
Review URL: http://codereview.chromium.org/2822010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49959 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rwxr-xr-x | chrome/chrome_tests.gypi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index e4dfbb9..cc9f177 100755 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -966,6 +966,7 @@ 'browser/translate/translate_manager2_unittest.cc', 'browser/user_style_sheet_watcher_unittest.cc', 'browser/views/accessibility_event_router_views_unittest.cc', + 'browser/views/bookmark_bar_view_unittest.cc', 'browser/views/bookmark_context_menu_test.cc', 'browser/views/bookmark_editor_view_unittest.cc', 'browser/views/extensions/browser_action_drag_data_unittest.cc', @@ -1089,6 +1090,7 @@ 'browser/renderer_host/gtk_key_bindings_handler_unittest.cc', ], 'sources!': [ + 'browser/views/bookmark_bar_view_unittest.cc', 'browser/views/bookmark_context_menu_test.cc', ], }], @@ -1116,6 +1118,7 @@ ['exclude', 'browser/gtk/reload_button_gtk_unittest\\.cc$'], ['exclude', 'browser/gtk/status_icons/status_tray_gtk_unittest\\.cc$'], ['exclude', 'browser/gtk/tabs/tab_renderer_gtk_unittest\\.cc$'], + ['include', 'browser/views/bookmark_bar_view_unittest.cc$'], ['include', 'browser/views/bookmark_context_menu_test.cc$'], ], }], @@ -1148,6 +1151,7 @@ 'browser/gtk/tabs/tab_renderer_gtk_unittest.cc', 'browser/password_manager/password_store_default_unittest.cc', 'browser/views/accessibility_event_router_views_unittest.cc', + 'browser/views/bookmark_bar_view_unittest.cc', 'browser/views/bookmark_context_menu_test.cc', 'tools/convert_dict/convert_dict_unittest.cc', '../third_party/hunspell/google/hunspell_tests.cc', |