gtk: Fix bookmark_utils::GetNodesFromSelection to not crash on invalid data.

BUG=43347
TEST=included
Review URL: http://codereview.chromium.org/2048002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46730 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 43 insertions, 42 deletions

diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 17bbb12..38452ee 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -553,17 +553,17 @@
         'browser/app_menu_model_unittest.cc',
         'browser/autocomplete/autocomplete_edit_unittest.cc',
         'browser/autocomplete/autocomplete_edit_view_mac_unittest.mm',
-        'browser/autocomplete/autocomplete_unittest.cc',
         'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm',
+        'browser/autocomplete/autocomplete_unittest.cc',
         'browser/autocomplete/history_contents_provider_unittest.cc',
         'browser/autocomplete/history_url_provider_unittest.cc',
         'browser/autocomplete/keyword_provider_unittest.cc',
         'browser/autocomplete/search_provider_unittest.cc',
         'browser/autofill/address_field_unittest.cc',
-        'browser/autofill/autofill_common_unittest.cc',
-        'browser/autofill/autofill_common_unittest.h',
         'browser/autofill/autofill_address_model_mac_unittest.mm',
         'browser/autofill/autofill_address_view_controller_mac_unittest.mm',
+        'browser/autofill/autofill_common_unittest.cc',
+        'browser/autofill/autofill_common_unittest.h',
         'browser/autofill/autofill_credit_card_model_mac_unittest.mm',
         'browser/autofill/autofill_credit_card_view_controller_mac_unittest.mm',
         'browser/autofill/autofill_dialog_controller_mac_unittest.mm',
@@ -598,20 +598,14 @@
         'browser/browser_theme_pack_unittest.cc',
         'browser/browser_theme_provider_unittest.cc',
         'browser/browser_unittest.cc',
-        'browser/content_setting_bubble_model_unittest.cc',
-        'browser/content_setting_image_model_unittest.cc',
-        'browser/chrome_browser_application_mac_unittest.mm',
-        'browser/debugger/devtools_remote_message_unittest.cc',
-        'browser/debugger/devtools_remote_listen_socket_unittest.cc',
-        'browser/debugger/devtools_remote_listen_socket_unittest.h',
-        'browser/diagnostics/diagnostics_model_unittest.cc',
         'browser/child_process_security_policy_unittest.cc',
+        'browser/chrome_browser_application_mac_unittest.mm',
         'browser/chrome_plugin_unittest.cc',
         'browser/chrome_thread_unittest.cc',
+        'browser/chromeos/cros/language_library_test.cc',
         'browser/chromeos/external_cookie_handler_unittest.cc',
         'browser/chromeos/external_metrics_unittest.cc',
         'browser/chromeos/gview_request_interceptor_unittest.cc',
-        'browser/chromeos/cros/language_library_test.cc',
         'browser/chromeos/login/cookie_fetcher_unittest.cc',
         'browser/chromeos/login/google_authenticator_unittest.cc',
         'browser/chromeos/login/mock_auth_response_handler.cc',
@@ -619,6 +613,12 @@
         'browser/chromeos/pipe_reader_unittest.cc',
         'browser/chromeos/status/language_menu_l10n_util_unittest.cc',
         'browser/chromeos/version_loader_unittest.cc',
+        'browser/content_setting_bubble_model_unittest.cc',
+        'browser/content_setting_image_model_unittest.cc',
+        'browser/debugger/devtools_remote_listen_socket_unittest.cc',
+        'browser/debugger/devtools_remote_listen_socket_unittest.h',
+        'browser/debugger/devtools_remote_message_unittest.cc',
+        'browser/diagnostics/diagnostics_model_unittest.cc',
         # It is safe to list */cocoa/* files in the "common" file list
         # without an explicit exclusion since gyp is smart enough to
         # exclude them from non-Mac builds.
@@ -629,9 +629,9 @@
         'browser/cocoa/autocomplete_text_field_editor_unittest.mm',
         'browser/cocoa/autocomplete_text_field_unittest.mm',
         'browser/cocoa/autocomplete_text_field_unittest_helper.mm',
-        'browser/cocoa/base_view_unittest.mm',
         'browser/cocoa/background_gradient_view_unittest.mm',
         'browser/cocoa/background_tile_view_unittest.mm',
+        'browser/cocoa/base_view_unittest.mm',
         'browser/cocoa/bookmark_all_tabs_controller_unittest.mm',
         'browser/cocoa/bookmark_bar_bridge_unittest.mm',
         'browser/cocoa/bookmark_bar_controller_unittest.mm',
@@ -645,14 +645,14 @@
         'browser/cocoa/bookmark_bar_unittest_helper.mm',
         'browser/cocoa/bookmark_bar_view_unittest.mm',
         'browser/cocoa/bookmark_bubble_controller_unittest.mm',
-        'browser/cocoa/bookmark_button_unittest.mm',
         'browser/cocoa/bookmark_button_cell_unittest.mm',
+        'browser/cocoa/bookmark_button_unittest.mm',
         'browser/cocoa/bookmark_editor_base_controller_unittest.mm',
         'browser/cocoa/bookmark_editor_controller_unittest.mm',
         'browser/cocoa/bookmark_folder_target_unittest.mm',
-        'browser/cocoa/bookmark_menu_unittest.mm',
         'browser/cocoa/bookmark_menu_bridge_unittest.mm',
         'browser/cocoa/bookmark_menu_cocoa_controller_unittest.mm',
+        'browser/cocoa/bookmark_menu_unittest.mm',
         'browser/cocoa/bookmark_model_observer_for_cocoa_unittest.mm',
         'browser/cocoa/bookmark_name_folder_controller_unittest.mm',
         'browser/cocoa/bookmark_tree_browser_cell_unittest.mm',
@@ -671,10 +671,10 @@
         'browser/cocoa/content_blocked_bubble_controller_unittest.mm',
         'browser/cocoa/content_exceptions_window_controller_unittest.mm',
         'browser/cocoa/content_settings_dialog_controller_unittest.mm',
-        'browser/cocoa/cookies_window_controller_unittest.mm',
-        'browser/cocoa/cookie_prompt_window_controller_unittest.mm',
         'browser/cocoa/cookie_details_unittest.mm',
         'browser/cocoa/cookie_details_view_controller_unittest.mm',
+        'browser/cocoa/cookie_prompt_window_controller_unittest.mm',
+        'browser/cocoa/cookies_window_controller_unittest.mm',
         'browser/cocoa/custom_home_pages_model_unittest.mm',
         'browser/cocoa/delayedmenu_button_unittest.mm',
         'browser/cocoa/disclosure_view_controller_unittest.mm',
@@ -684,16 +684,16 @@
         'browser/cocoa/download_util_mac_unittest.mm',
         'browser/cocoa/draggable_button_unittest.mm',
         'browser/cocoa/edit_search_engine_cocoa_controller_unittest.mm',
+        'browser/cocoa/event_utils_unittest.mm',
         'browser/cocoa/extension_installed_bubble_controller_unittest.mm',
         'browser/cocoa/extensions/browser_actions_container_view_unittest.mm',
         'browser/cocoa/extensions/extension_install_prompt_controller_unittest.mm',
         'browser/cocoa/extensions/extension_popup_controller_unittest.mm',
-        'browser/cocoa/event_utils_unittest.mm',
         'browser/cocoa/fast_resize_view_unittest.mm',
         'browser/cocoa/find_bar_bridge_unittest.mm',
         'browser/cocoa/find_bar_cocoa_controller_unittest.mm',
-        'browser/cocoa/find_bar_text_field_unittest.mm',
         'browser/cocoa/find_bar_text_field_cell_unittest.mm',
+        'browser/cocoa/find_bar_text_field_unittest.mm',
         'browser/cocoa/find_bar_view_unittest.mm',
         'browser/cocoa/find_pasteboard_unittest.mm',
         'browser/cocoa/floating_bar_backing_view_unittest.mm',
@@ -701,8 +701,12 @@
         'browser/cocoa/font_language_settings_controller_unittest.mm',
         'browser/cocoa/fullscreen_window_unittest.mm',
         'browser/cocoa/geolocation_exceptions_window_controller_unittest.mm',
+        'browser/cocoa/gradient_button_cell_unittest.mm',
+        'browser/cocoa/history_menu_bridge_unittest.mm',
+        'browser/cocoa/history_menu_cocoa_controller_unittest.mm',
         'browser/cocoa/html_dialog_window_controller_unittest.mm',
         'browser/cocoa/hung_renderer_controller_unittest.mm',
+        'browser/cocoa/hyperlink_button_cell_unittest.mm',
         'browser/cocoa/import_settings_dialog_unittest.mm',
         'browser/cocoa/info_bubble_view_unittest.mm',
         'browser/cocoa/info_bubble_window_unittest.mm',
@@ -712,10 +716,6 @@
         'browser/cocoa/keystone_glue_unittest.mm',
         'browser/cocoa/keyword_editor_cocoa_controller_unittest.mm',
         'browser/cocoa/location_bar_view_mac_unittest.mm',
-        'browser/cocoa/gradient_button_cell_unittest.mm',
-        'browser/cocoa/history_menu_bridge_unittest.mm',
-        'browser/cocoa/history_menu_cocoa_controller_unittest.mm',
-        'browser/cocoa/hyperlink_button_cell_unittest.mm',
         'browser/cocoa/menu_button_unittest.mm',
         'browser/cocoa/menu_controller_unittest.mm',
         'browser/cocoa/notifications/balloon_controller_unittest.mm',
@@ -731,10 +731,10 @@
         'browser/cocoa/section_separator_view_unittest.mm',
         'browser/cocoa/status_bubble_mac_unittest.mm',
         'browser/cocoa/status_icons/status_icon_mac_unittest.mm',
+        'browser/cocoa/styled_text_field_cell_unittest.mm',
         'browser/cocoa/styled_text_field_test_helper.h',
         'browser/cocoa/styled_text_field_test_helper.mm',
         'browser/cocoa/styled_text_field_unittest.mm',
-        'browser/cocoa/styled_text_field_cell_unittest.mm',
         'browser/cocoa/sync_customize_controller_unittest.mm',
         'browser/cocoa/tab_controller_unittest.mm',
         'browser/cocoa/tab_strip_controller_unittest.mm',
@@ -745,9 +745,9 @@
         'browser/cocoa/test_event_utils.h',
         'browser/cocoa/test_event_utils.mm',
         'browser/cocoa/throbber_view_unittest.mm',
-        'browser/cocoa/translate_infobar_unittest.mm',
         'browser/cocoa/toolbar_controller_unittest.mm',
         'browser/cocoa/toolbar_view_unittest.mm',
+        'browser/cocoa/translate_infobar_unittest.mm',
         'browser/cocoa/vertical_layout_view_unittest.mm',
         'browser/cocoa/view_resizer_pong.h',
         'browser/cocoa/view_resizer_pong.mm',
@@ -790,14 +790,15 @@
         'browser/geolocation/wifi_data_provider_common_unittest.cc',
         'browser/geolocation/wifi_data_provider_unittest_win.cc',
         'browser/global_keyboard_shortcuts_mac_unittest.mm',
-        'browser/google_url_tracker_unittest.cc',
         'browser/google_update_settings_unittest.cc',
+        'browser/google_url_tracker_unittest.cc',
         'browser/gtk/bookmark_bar_gtk_unittest.cc',
         'browser/gtk/bookmark_editor_gtk_unittest.cc',
+        'browser/gtk/bookmark_utils_gtk_unittest.cc',
+        'browser/gtk/go_button_gtk_unittest.cc',
         'browser/gtk/gtk_chrome_shrinkable_hbox_unittest.cc',
         'browser/gtk/gtk_expanded_container_unittest.cc',
         'browser/gtk/gtk_theme_provider_unittest.cc',
-        'browser/gtk/go_button_gtk_unittest.cc',
         'browser/gtk/keyword_editor_view_unittest.cc',
         'browser/gtk/options/cookies_view_unittest.cc',
         'browser/gtk/options/languages_page_gtk_unittest.cc',
@@ -815,22 +816,21 @@
         'browser/history/text_database_unittest.cc',
         'browser/history/thumbnail_database_unittest.cc',
         'browser/history/top_sites_unittest.cc',
-        'browser/host_content_settings_map_unittest.cc',
-        'browser/host_zoom_map_unittest.cc',
-        'browser/thumbnail_store_unittest.cc',
         'browser/history/url_database_unittest.cc',
         'browser/history/visit_database_unittest.cc',
         'browser/history/visit_tracker_unittest.cc',
+        'browser/host_content_settings_map_unittest.cc',
+        'browser/host_zoom_map_unittest.cc',
         'browser/important_file_writer_unittest.cc',
-        'browser/importer/firefox_importer_unittest_messages_internal.h',
         'browser/importer/firefox_importer_unittest.cc',
+        'browser/importer/firefox_importer_unittest_messages_internal.h',
         'browser/importer/firefox_importer_unittest_utils.h',
         'browser/importer/firefox_importer_unittest_utils_mac.cc',
+        'browser/importer/firefox_profile_lock_unittest.cc',
         'browser/importer/firefox_proxy_settings_unittest.cc',
         'browser/importer/importer_unittest.cc',
         'browser/importer/safari_importer_unittest.mm',
         'browser/importer/toolbar_importer_unittest.cc',
-        'browser/importer/firefox_profile_lock_unittest.cc',
         'browser/in_process_webkit/dom_storage_dispatcher_host_unittest.cc',
         'browser/in_process_webkit/webkit_context_unittest.cc',
         'browser/in_process_webkit/webkit_thread_unittest.cc',
@@ -838,13 +838,13 @@
         'browser/keychain_mock_mac.cc',
         'browser/keychain_mock_mac.h',
         'browser/login_prompt_unittest.cc',
-        'browser/meta_table_helper_unittest.cc',
         'browser/mach_broker_mac_unittest.cc',
+        'browser/meta_table_helper_unittest.cc',
         'browser/metrics/metrics_log_unittest.cc',
         'browser/metrics/metrics_response_unittest.cc',
         'browser/metrics/metrics_service_unittest.cc',
-        'browser/net/connection_tester_unittest.cc',
         'browser/net/chrome_url_request_context_unittest.cc',
+        'browser/net/connection_tester_unittest.cc',
         'browser/net/dns_host_info_unittest.cc',
         'browser/net/dns_master_unittest.cc',
         'browser/net/passive_log_collector_unittest.cc',
@@ -859,9 +859,9 @@
         'browser/page_menu_model_unittest.cc',
         'browser/password_manager/encryptor_unittest.cc',
         'browser/password_manager/login_database_unittest.cc',
+        'browser/password_manager/password_form_data.cc',
         'browser/password_manager/password_form_manager_unittest.cc',
         'browser/password_manager/password_manager_unittest.cc',
-        'browser/password_manager/password_form_data.cc',
         'browser/password_manager/password_store_default_unittest.cc',
         'browser/password_manager/password_store_mac_unittest.cc',
         'browser/password_manager/password_store_win_unittest.cc',
@@ -922,15 +922,15 @@
         'browser/sync/glue/theme_util_unittest.cc',
         'browser/sync/glue/typed_url_model_associator_unittest.cc',
         'browser/sync/glue/ui_model_worker_unittest.cc',
-        'browser/sync/profile_sync_service_mock.h',
-        'browser/sync/profile_sync_service_startup_unittest.cc',
-        'browser/sync/profile_sync_service_unittest.cc',
         'browser/sync/profile_sync_factory_impl_unittest.cc',
         'browser/sync/profile_sync_factory_mock.cc',
         'browser/sync/profile_sync_factory_mock.h',
         'browser/sync/profile_sync_service_autofill_unittest.cc',
+        'browser/sync/profile_sync_service_mock.h',
         'browser/sync/profile_sync_service_preference_unittest.cc',
+        'browser/sync/profile_sync_service_startup_unittest.cc',
         'browser/sync/profile_sync_service_typed_url_unittest.cc',
+        'browser/sync/profile_sync_service_unittest.cc',
         'browser/sync/profile_sync_test_util.h',
         'browser/sync/sync_setup_wizard_unittest.cc',
         'browser/sync/sync_ui_util_mac_unittest.mm',
@@ -945,8 +945,9 @@
         'browser/tabs/pinned_tab_codec_unittest.cc',
         'browser/tabs/tab_strip_model_unittest.cc',
         'browser/task_manager_unittest.cc',
-        'browser/translate/translate_manager_unittest.cc',
         'browser/theme_resources_util_unittest.cc',
+        'browser/thumbnail_store_unittest.cc',
+        'browser/translate/translate_manager_unittest.cc',
         'browser/user_style_sheet_watcher_unittest.cc',
         'browser/views/accessibility_event_router_views_unittest.cc',
         'browser/views/bookmark_context_menu_test.cc',
@@ -965,13 +966,13 @@
         'common/deprecated/event_sys_unittest.cc',
         'common/desktop_notifications/active_notification_tracker_unittest.cc',
         'common/extensions/extension_action_unittest.cc',
+        'common/extensions/extension_extent_unittest.cc',
         'common/extensions/extension_file_util_unittest.cc',
         'common/extensions/extension_l10n_util_unittest.cc',
         'common/extensions/extension_manifests_unittest.cc',
         'common/extensions/extension_message_bundle_unittest.cc',
         'common/extensions/extension_message_filter_peer_unittest.cc',
         'common/extensions/extension_resource_unittest.cc',
-        'common/extensions/extension_extent_unittest.cc',
         'common/extensions/extension_unittest.cc',
         'common/extensions/extension_unpacker_unittest.cc',
         'common/extensions/update_manifest_unittest.cc',
@@ -990,11 +991,11 @@
         'common/worker_thread_ticker_unittest.cc',
         'common/zip_unittest.cc',
         'renderer/audio_message_filter_unittest.cc',
-        'renderer/form_manager_unittest.cc',
-        'renderer/media/audio_renderer_impl_unittest.cc',
-        'renderer/extensions/extension_api_json_validity_unittest.cc',
         'renderer/extensions/extension_api_client_unittest.cc',
+        'renderer/extensions/extension_api_json_validity_unittest.cc',
         'renderer/extensions/json_schema_unittest.cc',
+        'renderer/form_manager_unittest.cc',
+        'renderer/media/audio_renderer_impl_unittest.cc',
         'renderer/net/render_dns_master_unittest.cc',
         'renderer/net/render_dns_queue_unittest.cc',
         'renderer/paint_aggregator_unittest.cc',