diff options
author | knn <knn@chromium.org> | 2015-06-26 11:18:42 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-06-26 18:19:43 +0000 |
commit | 062cdbbade5d2c804bce7ff7b320d36cb97c39da (patch) | |
tree | 2e2da2b1023978d534cb8def177cd6079eb027d7 /chrome/chrome_tests.gypi | |
parent | 0bd407f3979d07dad729c5edfbd6d9e2d399867f (diff) | |
download | chromium_src-062cdbbade5d2c804bce7ff7b320d36cb97c39da.zip chromium_src-062cdbbade5d2c804bce7ff7b320d36cb97c39da.tar.gz chromium_src-062cdbbade5d2c804bce7ff7b320d36cb97c39da.tar.bz2 |
Introduce a layering in the invalidation component as public and impl.
The invalidation component has dependencies due to specific
implementations of the inv_client, inv_service etc.
Consumers of invalidations do not need to depend on these.
This change exports the InvalidationHandler interface in a separate target
'invalidation_public' which only depends on //google/cacheinvalidation
Thus the signin component can implement to InvalidationHandler to refresh
account information without introducing a cyclic dependency.
The crux of the change is:
Move {components/invalidation/ => components/invalidation/public}:
-ack_handle.cc
-ack_handle.h
-ack_handler.cc
-ack_handler.h
-invalidation.cc
-invalidation.h
-invalidation_export.h
-invalidation_handler.cc
-invalidation_handler.h
-invalidation_service.h
-invalidation_util.cc
-invalidation_util.h
-invalidator_state.cc
-invalidator_state.h
-object_id_invalidation_map.cc
-object_id_invalidation_map.h
-single_object_invalidation_set.cc
-single_object_invalidation_set.h
Move {components/invalidation/ => components/invalidation/impl}:
other files
Thus the dependency chain is:
//chrome/browser/ -> //components/invalidation/impl -> components/invalidation/public
Now invalidation consumers can directly depend on //components/invalidation/public
which has only //google/cacheinvalidation has a dependency.
BUG=503131
Review URL: https://codereview.chromium.org/1191393008
Cr-Commit-Position: refs/heads/master@{#336413}
Diffstat (limited to 'chrome/chrome_tests.gypi')
-rw-r--r-- | chrome/chrome_tests.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index fc6f020..98c85c2 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -2678,7 +2678,7 @@ 'chrome', 'test_support_common', '../base/base.gyp:base', - '../components/components.gyp:invalidation', + '../components/components.gyp:invalidation_impl', '../components/components.gyp:invalidation_test_support', '../net/net.gyp:net', '../skia/skia.gyp:skia', |