diff options
| author | jackhou <jackhou@chromium.org> | 2015-07-29 20:11:18 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-30 03:11:48 +0000 |
| commit | 06c25a9881b76f7e0b0ab27050d8c470fe9bdc2d (patch) | |
| tree | b8156b9a571eb68c33ab42f9a185292f8263a504 /chrome/chrome_tests.gypi | |
| parent | 1eb12db3dbd38d63376994a1d684bdbc858dcf2c (diff) | |
| download | chromium_src-06c25a9881b76f7e0b0ab27050d8c470fe9bdc2d.zip chromium_src-06c25a9881b76f7e0b0ab27050d8c470fe9bdc2d.tar.gz chromium_src-06c25a9881b76f7e0b0ab27050d8c470fe9bdc2d.tar.bz2 | |
[Mac] Remove BrowserCommandExecutor protocol.
Only BrowserWindowController implements this. Other implementors just
turn it into a no-op. ChromeEventProcessingWindow (CEPW) now simply
checks whether it's a Browser window and executes the command.
This is the first step to factor out keyboard shortcut handling in CEPW into
a component that can be reused in Views as it removes one (of two)
dependencies on -[NSWindow windowController], which cannot be used
to implement browser-side behavior under Views.
Added new browser_test for shortcuts in global_keyboard_shortcuts_mac.
Some history:
BrowserCommandExecutor was added in r30619 (6 years ago) to allow a
non-browser window to execute browser commands, but became obsolete
a month later in r32445 when HtmlDialogWindowController (now
WebDialogWindowController) decided to ignore those commands instead.
BUG=508438
Review URL: https://codereview.chromium.org/1250533003
Cr-Commit-Position: refs/heads/master@{#341062}
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rw-r--r-- | chrome/chrome_tests.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 943e5b3..e263909 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -294,6 +294,7 @@ 'browser/first_run/try_chrome_dialog_view_browsertest.cc', 'browser/geolocation/access_token_store_browsertest.cc', 'browser/geolocation/geolocation_browsertest.cc', + 'browser/global_keyboard_shortcuts_mac_browsertest.mm', 'browser/history/history_browsertest.cc', 'browser/history/redirect_browsertest.cc', 'browser/iframe_browsertest.cc', |