diff options
| author | noel <noel@chromium.org> | 2015-07-13 04:30:07 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-13 11:30:38 +0000 |
| commit | 7b908c0aedf17bed5a8099a47d872b58b7badfde (patch) | |
| tree | 0f6341fe7b171ddb88276e5aca8383a8965fdbda /chrome/chrome_tests.gypi | |
| parent | 403ea1d7c6c7708d7302320777427df2d240db88 (diff) | |
| download | chromium_src-7b908c0aedf17bed5a8099a47d872b58b7badfde.zip chromium_src-7b908c0aedf17bed5a8099a47d872b58b7badfde.tar.gz chromium_src-7b908c0aedf17bed5a8099a47d872b58b7badfde.tar.bz2 | |
Revert of Add support for escaped target names in isolate driver (4th try) (patchset #2 id:20001 of https://codereview.chromium.org/1221333013/)
Reason for revert:
Speculative revert: appreas to have broken the GPU mac builders.
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141
Original issue's description:
> Add support for escaped target names in isolate driver (4th try)
>
> Currently the isolate_driver.py which creates the dependency files
> used by the isolate system, does a simple split on all spaces when
> trying to identify targets.
>
> This can fail if the target name contains a space in the name. In
> ninja, spaces are escaped with a $-prefix. An example would be
> 'Content$ Shell$ Helper.app'.
>
> This CL adds support for such target names and ensures that they
> stay as one item. Doing this uncovered a few missing dependencies
> and a missing file in some .isolate-files for the component build
> on Mac.
>
> 1st try: https://codereview.chromium.org/970203003/
> 1st revert: https://codereview.chromium.org/985753002/
> 2nd try: https://codereview.chromium.org/1103793002/
> 2nd revert: https://codereview.chromium.org/1129493003/
> 3rd try: https://codereview.chromium.org/1130523003/
> 3rd revert: https://codereview.chromium.org/1131363003/
> BUG=462248
>
> Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f
> Cr-Commit-Position: refs/heads/master@{#338402}
TBR=thakis@chromium.org,vadimsh@chromium.org,nyquist@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462248
Review URL: https://codereview.chromium.org/1227843004
Cr-Commit-Position: refs/heads/master@{#338497}
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rw-r--r-- | chrome/chrome_tests.gypi | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 7c28595..00e1932 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -3178,7 +3178,6 @@ 'target_name': 'interactive_ui_tests_run', 'type': 'none', 'dependencies': [ - 'chrome', 'interactive_ui_tests', ], 'conditions': [ @@ -3199,7 +3198,6 @@ 'target_name': 'sync_integration_tests_run', 'type': 'none', 'dependencies': [ - 'chrome', 'sync_integration_tests', ], 'conditions': [ |