diff options
| author | lazyboy <lazyboy@chromium.org> | 2015-07-21 03:12:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-21 10:12:57 +0000 |
| commit | 87a98e428afa9dff6d02ff37d1504411d40fda3d (patch) | |
| tree | d55359ccb440c1ec9cd34b6c59e8145eb59756b4 /chrome/chrome_tests.gypi | |
| parent | be38b7a2c60c18dd2b3697a80241561f048d5260 (diff) | |
| download | chromium_src-87a98e428afa9dff6d02ff37d1504411d40fda3d.zip chromium_src-87a98e428afa9dff6d02ff37d1504411d40fda3d.tar.gz chromium_src-87a98e428afa9dff6d02ff37d1504411d40fda3d.tar.bz2 | |
Fix nested GuestView's container bounds calculation.
This results in incorrect context menu positioning in pdf in webview or
webview inside appview.
If a guest A is nested within an embedder B, which in turn is nested inside
an embedder C, then we used to add offset twice to calculate the bounds of A
because BrowserPluginGuest::GetScreenCoordinates would add:
1. offset of C from A and
2. offset of B from A.
This CL removes step #2.
From logs, it seems to be there from the beginning of appview implementation.
BUG=507223
Test=Load a PDF inside <webview> and check context menu inside the PDF.
Easier to test with the browser sample:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser
You should observe the context menu is shown in the right place instead of
it being shifted.
Review URL: https://codereview.chromium.org/1237343002
Cr-Commit-Position: refs/heads/master@{#339635}
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rw-r--r-- | chrome/chrome_tests.gypi | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 5c2ff3e..b4e897c 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -355,6 +355,8 @@ 'browser/net/websocket_browsertest.cc', 'browser/password_manager/password_manager_browsertest.cc', 'browser/pdf/pdf_extension_test.cc', + 'browser/pdf/pdf_extension_test_util.cc', + 'browser/pdf/pdf_extension_test_util.h', 'browser/plugins/plugin_power_saver_browsertest.cc', 'browser/prefetch/prefetch_browsertest.cc', 'browser/prefs/pref_functional_browsertest.cc', |