Simplify OneShotTimer and RepeatingTimer. Fix up all consumers.

Major changes:

OneShotTimer and RepeatingTimer become template classes that no longer require
a Task or a Timer object.  They just use PostDelayedTask.  Under the hood that
still uses a Timer object.

The API is much simpler for consumers as they now no longer need to worry about
allocating a Task or managing the lifetime of the object pointer held by the
Task.

I added some new unit tests to timer_unittest.cc to cover the API.

I preserved the old TimerManager / Timer API for now, but I plan to soon kill
it.

R=brettw
BUG=1346553



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1502 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 6 deletions

diff --git a/chrome/common/animation.h b/chrome/common/animation.h
index 3505fe6..657512a 100644
--- a/chrome/common/animation.h
+++ b/chrome/common/animation.h
@@ -6,7 +6,6 @@
 #ifndef CHROME_COMMON_ANIMATION_H__
 #define CHROME_COMMON_ANIMATION_H__
 
-#include "base/task.h"
 #include "base/timer.h"
 
 class Animation;
@@ -48,7 +47,7 @@ class AnimationDelegate {
 //  initialization specific to the subclass, and then call |Start|. The
 //  animation uses the current thread's message loop.
 //
-class Animation : public Task {
+class Animation {
  public:
   // Initializes everything except the duration.
   //
@@ -86,14 +85,14 @@ class Animation : public Task {
   // Return whether this animation is animating.
   bool IsAnimating();
 
-  // The animation's Task::Run implementation
-  virtual void Run();
-
   // Changes the length of the animation. This resets the current
   // state of the animation to the beginning.
   void SetDuration(int duration);
 
  protected:
+  // Called when the animation's timer expires.
+  void Run();
+
   // Calculates the timer interval from the constructor list.
   int CalculateInterval(int frame_rate);
 
@@ -111,7 +110,7 @@ class Animation : public Task {
 
   AnimationDelegate* delegate_;
 
-  RepeatingTimer timer_;
+  base::RepeatingTimer<Animation> timer_;
 
   DISALLOW_EVIL_CONSTRUCTORS(Animation);
 };