diff options
author | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-15 20:40:08 +0000 |
---|---|---|
committer | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-15 20:40:08 +0000 |
commit | 1b9575b6c17f75992713555056dceadf4770c565 (patch) | |
tree | 1dd5274380adfb20545affdd9a67a0353c8cb9dd /chrome/common/child_process_logging_linux.cc | |
parent | eb1b21a1d1425b5da525ba18946ba94454509ccb (diff) | |
download | chromium_src-1b9575b6c17f75992713555056dceadf4770c565.zip chromium_src-1b9575b6c17f75992713555056dceadf4770c565.tar.gz chromium_src-1b9575b6c17f75992713555056dceadf4770c565.tar.bz2 |
Revert 101372 - Linux: Add more information to crash reports:
Reason for revert: Broke clang compile.
- number of extensions
- up to 10 extension IDs
- number of views
- number of switches
- up to 15 switches
BUG=60993,82977
TEST=none
Review URL: http://codereview.chromium.org/7886057
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/7915004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101373 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/child_process_logging_linux.cc')
-rw-r--r-- | chrome/common/child_process_logging_linux.cc | 50 |
1 files changed, 5 insertions, 45 deletions
diff --git a/chrome/common/child_process_logging_linux.cc b/chrome/common/child_process_logging_linux.cc index 185da04..28b9a2e 100644 --- a/chrome/common/child_process_logging_linux.cc +++ b/chrome/common/child_process_logging_linux.cc @@ -4,8 +4,6 @@ #include "chrome/common/child_process_logging.h" -#include "base/command_line.h" -#include "base/format_macros.h" #include "base/string_number_conversions.h" #include "base/string_util.h" #include "base/utf_string_conversions.h" @@ -33,19 +31,6 @@ char g_gpu_driver_ver[kGpuStringSize] = ""; char g_gpu_ps_ver[kGpuStringSize] = ""; char g_gpu_vs_ver[kGpuStringSize] = ""; -static const size_t kNumSize = 32; -char g_num_extensions[kNumSize] = ""; -char g_num_switches[kNumSize] = ""; -char g_num_views[kNumSize] = ""; - -static const size_t kMaxExtensionSize = - kExtensionLen * kMaxReportedActiveExtensions + 1; -char g_extension_ids[kMaxExtensionSize] = ""; - -// Assume command line switches are less than 64 chars. -static const size_t kMaxSwitchesSize = kSwitchLen * kMaxSwitches + 1; -char g_switches[kMaxSwitchesSize] = ""; - void SetActiveURL(const GURL& url) { base::strlcpy(g_active_url, url.possibly_invalid_spec().c_str(), @@ -69,18 +54,7 @@ std::string GetClientId() { } void SetActiveExtensions(const std::set<std::string>& extension_ids) { - snprintf(g_num_extensions, kNumSize - 1, "%" PRIuS, extension_ids.size()); - g_num_extensions[kNumSize - 1] = '\0'; - - std::string extension_str; - std::set<std::string>::const_iterator iter = extension_ids.begin(); - for (int i = 0; - i < kMaxReportedActiveExtensions && iter != extension_ids.end(); - ++i, ++iter) { - extension_str += *iter; - } - strncpy(g_extension_ids, extension_str.c_str(), kMaxExtensionSize - 1); - g_extension_ids[kMaxExtensionSize - 1] = '\0'; + // TODO(port) } void SetGpuInfo(const GPUInfo& gpu_info) { @@ -101,26 +75,12 @@ void SetGpuInfo(const GPUInfo& gpu_info) { } void SetNumberOfViews(int number_of_views) { - snprintf(g_num_views, kNumSize - 1, "%d", number_of_views); - g_num_views[kNumSize - 1] = '\0'; + // TODO(port) } -void SetCommandLine(const CommandLine* command_line) { - const CommandLine::StringVector& argv = command_line->argv(); - - snprintf(g_num_switches, kNumSize - 1, "%lu", argv.size() - 1); - g_num_switches[kNumSize - 1] = '\0'; - - std::string command_line_str; - for (size_t argv_i = 1; - argv_i < argv.size() && argv_i <= kMaxSwitches; - ++argv_i) { - command_line_str += argv[argv_i]; - // Truncate long switches, align short ones with spaces to be trimmed later. - command_line_str.resize(argv_i * kSwitchLen, ' '); - } - strncpy(g_switches, command_line_str.c_str(), kMaxSwitchesSize - 1); - g_switches[kMaxSwitchesSize - 1] = '\0'; +void SetCommandLine(const CommandLine*) { + // TODO: http://crbug.com/60993 + NOTIMPLEMENTED(); } } // namespace child_process_logging |