diff options
author | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 05:07:55 +0000 |
---|---|---|
committer | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 05:07:55 +0000 |
commit | 2c58efc6135102d815c34d518d14c0bfc5c27f5b (patch) | |
tree | bf47fee779ada375a0007e4cc7b527e86a0293a3 /chrome/common/child_process_logging_win.cc | |
parent | 48844c643cca3d7d21043e46c228585e68618e31 (diff) | |
download | chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.zip chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.tar.gz chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.tar.bz2 |
Revert 33255 - Report active extensions in crash reports. This only implements Windows right now. Mac and linux will be separate CLs.
"Active" is overloaded to mean different things depending on
the process type:
browser: all enabled extensions
renderer: unique set of extensions from all user scripts
extension: extensions running in the process
BUG=27169
Review URL: http://codereview.chromium.org/437078
--
There are thousands of new crashes with reivison 33256 and 33255, so i'm
reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/448006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/child_process_logging_win.cc')
-rw-r--r-- | chrome/common/child_process_logging_win.cc | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/chrome/common/child_process_logging_win.cc b/chrome/common/child_process_logging_win.cc index 9a11e8f..94b77d8 100644 --- a/chrome/common/child_process_logging_win.cc +++ b/chrome/common/child_process_logging_win.cc @@ -7,7 +7,6 @@ #include <windows.h> #include "base/string_util.h" -#include "chrome/app/breakpad_win.h" #include "chrome/common/chrome_constants.h" #include "chrome/installer/util/google_update_settings.h" #include "googleurl/src/gurl.h" @@ -19,10 +18,6 @@ typedef void (__cdecl *MainSetActiveURL)(const wchar_t*); // exported in breakpad_win.cc: void __declspec(dllexport) __cdecl SetClientId. typedef void (__cdecl *MainSetClientId)(const wchar_t*); -// exported in breakpad_win.cc: -// void __declspec(dllexport) __cdecl SetExtensionID. -typedef void (__cdecl *MainSetExtensionID)(size_t, const wchar_t*); - void SetActiveURL(const GURL& url) { static MainSetActiveURL set_active_url = NULL; // note: benign race condition on set_active_url. @@ -66,24 +61,4 @@ void SetClientId(const std::string& client_id) { (set_client_id)(wstr.c_str()); } -void SetActiveExtensions(const std::vector<std::string>& extension_ids) { - static MainSetExtensionID set_extension_id = NULL; - if (!set_extension_id) { - HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName); - if (!exe_module) - return; - set_extension_id = reinterpret_cast<MainSetExtensionID>( - GetProcAddress(exe_module, "SetExtensionID")); - if (!set_extension_id) - return; - } - - for (size_t i = 0; i < kMaxReportedActiveExtensions; ++i) { - if (i < extension_ids.size()) - (set_extension_id)(i, ASCIIToWide(extension_ids[i].c_str()).c_str()); - else - (set_extension_id)(i, L""); - } -} - } // namespace child_process_logging |