diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-27 22:18:54 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-27 22:18:54 +0000 |
commit | 4c690c58e30ac10d555731cb94307f1bf323a620 (patch) | |
tree | 439f1e0fbb91c6e4a1c7b7a6fbcbadd648c06078 /chrome/common/chrome_constants.h | |
parent | e7b755275ea9426d0943b06c66cb861a3a0ca85f (diff) | |
download | chromium_src-4c690c58e30ac10d555731cb94307f1bf323a620.zip chromium_src-4c690c58e30ac10d555731cb94307f1bf323a620.tar.gz chromium_src-4c690c58e30ac10d555731cb94307f1bf323a620.tar.bz2 |
Fix 12729: Find box doesn't unregister Esc accelerator.
This regressed recently during porting. When
comparing to see who is registered we need to
be comparing against a class that implements
FocusChangeListener (and registers as such
with AddFocusChangeListener). In this case,
host_ does not implement that interface and
doesn't register as a listener, so it will
never be registered. We should be comparing
using 'this', not 'host_'.
I've fixed this and added a browser_test to
catch this in the future.
BUG=12729
TEST=Open Find, press Esc, press Esc again
and the Find box should not briefly appear
and hide again. Also, make sure Esc works
to cancel navigations.
Review URL: http://codereview.chromium.org/115832
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17032 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/chrome_constants.h')
0 files changed, 0 insertions, 0 deletions