diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
| commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
| tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /chrome/common/content_settings_pattern_unittest.cc | |
| parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
| download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 | |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/content_settings_pattern_unittest.cc')
| -rw-r--r-- | chrome/common/content_settings_pattern_unittest.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/chrome/common/content_settings_pattern_unittest.cc b/chrome/common/content_settings_pattern_unittest.cc index 921f97b..c1c1e37 100644 --- a/chrome/common/content_settings_pattern_unittest.cc +++ b/chrome/common/content_settings_pattern_unittest.cc @@ -420,8 +420,8 @@ TEST(ContentSettingsPatternTest, InvalidPatterns) { EXPECT_STREQ("", ContentSettingsPattern().ToString().c_str()); // Empty pattern string - EXPECT_FALSE(Pattern("").IsValid()); - EXPECT_STREQ("", Pattern("").ToString().c_str()); + EXPECT_FALSE(Pattern(std::string()).IsValid()); + EXPECT_STREQ("", Pattern(std::string()).ToString().c_str()); // Pattern strings with invalid scheme part. EXPECT_FALSE(Pattern("ftp://myhost.org").IsValid()); @@ -630,8 +630,7 @@ TEST(ContentSettingsPatternTest, PatternSupport_Legacy) { EXPECT_TRUE( Pattern("file:///tmp/test.html").Matches( GURL("file:///tmp/test.html"))); - EXPECT_FALSE(Pattern("").Matches( - GURL("http://www.example.com/"))); + EXPECT_FALSE(Pattern(std::string()).Matches(GURL("http://www.example.com/"))); EXPECT_FALSE(Pattern("[*.]example.com").Matches( GURL("http://example.org/"))); EXPECT_FALSE(Pattern("example.com").Matches( |