Make CommandLine into a normal object, with some statics for getting at the current process's command line.

One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before.  (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.)

Review URL: http://codereview.chromium.org/18248


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 10 insertions, 8 deletions

diff --git a/chrome/common/debug_flags.h b/chrome/common/debug_flags.h
index 9d4ebba..c2115a9 100644
--- a/chrome/common/debug_flags.h
+++ b/chrome/common/debug_flags.h
@@ -5,7 +5,7 @@
 #ifndef CHROME_COMMON_DEBUG_FLAGS_H__
 #define CHROME_COMMON_DEBUG_FLAGS_H__
 
-#include <string>
+class CommandLine;
 
 class DebugFlags {
  public:
@@ -15,13 +15,15 @@ class DebugFlags {
     UNKNOWN
   };
 
-  // Updates the command line arguments with debug-related flags. If debug flags
-  // have been used with this process, they will be filtered and added to
-  // command_line as needed. is_in_sandbox must be true if the child process will
-  // be in a sandbox.
-  // Returns true if the caller should "help" the child process by calling the JIT
-  // debugger on it. It may only happen if is_in_sandbox is true.
-  static bool ProcessDebugFlags(std::wstring* command_line,
+  // Updates the command line arguments with debug-related flags. If
+  // debug flags have been used with this process, they will be
+  // filtered and added to command_line as needed. is_in_sandbox must
+  // be true if the child process will be in a sandbox.
+  //
+  // Returns true if the caller should "help" the child process by
+  // calling the JIT debugger on it. It may only happen if
+  // is_in_sandbox is true.
+  static bool ProcessDebugFlags(CommandLine* command_line,
                                 ChildProcessType type,
                                 bool is_in_sandbox);
 };