diff options
| author | twiz@google.com <twiz@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-16 23:28:26 +0000 |
|---|---|---|
| committer | twiz@google.com <twiz@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-16 23:28:26 +0000 |
| commit | b2725756d6f40456048f052427746f347dcd8219 (patch) | |
| tree | cf02ff046b428d9418291f0f7c6376ac71bbb1ea /chrome/common/extensions/api | |
| parent | ba1d6b0893d6d07cf1fb924f4212446d4e6136d4 (diff) | |
| download | chromium_src-b2725756d6f40456048f052427746f347dcd8219.zip chromium_src-b2725756d6f40456048f052427746f347dcd8219.tar.gz chromium_src-b2725756d6f40456048f052427746f347dcd8219.tar.bz2 | |
Refactoring of the chrome.experimental.popup API implementation to allow display of pop-ups for extensions viewed through a tab-contents view.I added a new class, ExtensionPopupHost. This class implements the necessary environment for managing child popup windows from either an ExtensionHost, or an ExtensionDOMUI. Note that this class is added as a member to ExtensionHost and ExtensionDOMUI.
I decided to take this approach to prevent multiple inheritance of the NotificationObserver class: Both ExtensionPopupHost and ExtensionHost must inherit from this class, and I was uncertain of how the system would behave wrt virtual inheritance. Please comment on if I should have used the inheritance approach.
I also removed the customHandler tag (in extension_api.json) that I had added in the initial submission. The arguments in the schema are now those that users of the API see. The nodocs tags were also removed.
The api experimental.popup.getAnchorWindow() has been renamed to popup.getParentWindow, as per a suggestion from Erik K.
BUG=none
TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/385061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32120 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/api')
| -rwxr-xr-x | chrome/common/extensions/api/extension_api.json | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json index ec16e65..4c83fdd 100755 --- a/chrome/common/extensions/api/extension_api.json +++ b/chrome/common/extensions/api/extension_api.json @@ -1649,7 +1649,6 @@ "name": "show", "type": "function", "description": "Displays a pop-up window hosting an extension view.", - "customHandler": "true", "parameters": [ { "type": "string", @@ -1665,7 +1664,7 @@ "properties": {}, "additionalProperties": { "type": "any" }, "isInstanceOf": "HTMLElement", - "description": "The HTMLElement whose position which serve as the anchor position of the popup." + "description": "A HTML DOM object to which the pop-up's position will be made relative." } } }, @@ -1677,7 +1676,7 @@ ] }, { - "name": "getAnchorWindow", + "name": "getParentWindow", "type": "function", "description": "Returns a reference to the window object of the extension view that launched the popup.", "parameters": [], |