diff options
| author | mmoss@google.com <mmoss@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-10 23:50:17 +0000 |
|---|---|---|
| committer | mmoss@google.com <mmoss@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-10 23:50:17 +0000 |
| commit | 81708681e34b50a58e00162d8553102ca5794d7f (patch) | |
| tree | 1b5705f986d270870fe9a4b5f16e1f8d91d618aa /chrome/common/extensions/docs/npapi.html | |
| parent | 761eb8d477ee56114a381b06bd7153bff1ea3097 (diff) | |
| download | chromium_src-81708681e34b50a58e00162d8553102ca5794d7f.zip chromium_src-81708681e34b50a58e00162d8553102ca5794d7f.tar.gz chromium_src-81708681e34b50a58e00162d8553102ca5794d7f.tar.bz2 | |
Don't force kill apache, and use the Apache-supplied PID for web server cleanup.
SIGKILL was causing Apache to leave semaphores hanging around, leading to resource starvation and Apache failures on the bots (see also http://rackerhacker.com/2007/08/24/apache-no-space-left-on-device-couldnt-create-accept-lock/).
Using the PID returned from Popen wasn't actually cleaning up anything, causing Apache processes to linger until the next run. Also change the shutdown method to just take a pid, since that's all it uses from the process object anyhow.
TEST=After running layout_test_wrapper.py (like http://chrome-buildbot.corp.google.com:8016/builders/Webkit%20Linux%2064%20(V8-Latest)/builds/5080/steps/webkit_tests/logs/stdio), there are no lingering chrome-bot semaphores (ipcs -s | grep chrome) or apache processes (ps aux | grep apache2)
Review URL: http://codereview.chromium.org/491025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34307 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/docs/npapi.html')
0 files changed, 0 insertions, 0 deletions