diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-29 18:27:01 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-29 18:27:01 +0000 |
| commit | c98c928aa38e31d44c7a792f0d12da84471639ff (patch) | |
| tree | 1e1050d39385fbdb787f5ae15dd2a38a143c8ebd /chrome/common/extensions/extension.cc | |
| parent | bab01969064bdb23cbd403aa86ddc85659d7b74e (diff) | |
| download | chromium_src-c98c928aa38e31d44c7a792f0d12da84471639ff.zip chromium_src-c98c928aa38e31d44c7a792f0d12da84471639ff.tar.gz chromium_src-c98c928aa38e31d44c7a792f0d12da84471639ff.tar.bz2 | |
Revert 79651 - Coverity: Pass parameters by reference.
Also remove an unused function that I found.
CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072,
8637,8718,8726
BUG=none
TEST=non
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6730046
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6773015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79705 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/extension.cc')
| -rw-r--r-- | chrome/common/extensions/extension.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc index e65d9e1..d6e0305 100644 --- a/chrome/common/extensions/extension.cc +++ b/chrome/common/extensions/extension.cc @@ -1266,7 +1266,8 @@ bool Extension::ParsePEMKeyBytes(const std::string& input, return base::Base64Decode(working, output); } -bool Extension::ProducePEM(const std::string& input, std::string* output) { +bool Extension::ProducePEM(const std::string& input, + std::string* output) { CHECK(output); if (input.length() == 0) return false; @@ -1274,7 +1275,7 @@ bool Extension::ProducePEM(const std::string& input, std::string* output) { return base::Base64Encode(input, output); } -bool Extension::FormatPEMForFileOutput(const std::string& input, +bool Extension::FormatPEMForFileOutput(const std::string input, std::string* output, bool is_public) { CHECK(output); |