summaryrefslogtreecommitdiffstats
path: root/chrome/common/extensions/extension.cc
diff options
context:
space:
mode:
authorerikkay@chromium.org <erikkay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-28 20:26:05 +0000
committererikkay@chromium.org <erikkay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-28 20:26:05 +0000
commit86c008e8a7da9c00c5a676eb201ba5d0c976748e (patch)
tree8e58aeeab8564a396ccf67807d5bddfcdaa05807 /chrome/common/extensions/extension.cc
parent5ec8d59c7e79d1a7aae4137051ffc184ec51096c (diff)
downloadchromium_src-86c008e8a7da9c00c5a676eb201ba5d0c976748e.zip
chromium_src-86c008e8a7da9c00c5a676eb201ba5d0c976748e.tar.gz
chromium_src-86c008e8a7da9c00c5a676eb201ba5d0c976748e.tar.bz2
override chrome:// URLs via extensions.
Overrides are declared in an extension's manifest. The last one installed wins. However, we keep a list of those installed per page so that priority is preserved and so that uninstall will revert to a previous state. Review URL: http://codereview.chromium.org/174277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24791 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/extension.cc')
-rw-r--r--chrome/common/extensions/extension.cc31
1 files changed, 31 insertions, 0 deletions
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index c826c07..3f3c8539 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -998,6 +998,37 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_id,
set_default_locale(default_locale);
}
+ // Chrome URL overrides (optional)
+ if (source.HasKey(keys::kChromeURLOverrides)) {
+ DictionaryValue* overrides;
+ if (!source.GetDictionary(keys::kChromeURLOverrides, &overrides)) {
+ *error = errors::kInvalidChromeURLOverrides;
+ return false;
+ }
+ // Validate that the overrides are all strings
+ DictionaryValue::key_iterator iter = overrides->begin_keys();
+ while (iter != overrides->end_keys()) {
+ // For now, only allow the new tab page. Others will work when we remove
+ // this check, but let's keep it simple for now.
+ // TODO(erikkay) enable other pages as well
+ if (WideToUTF8(*iter) != chrome::kChromeUINewTabHost) {
+ *error = errors::kInvalidChromeURLOverrides;
+ return false;
+ }
+ std::string val;
+ if (!overrides->GetString(*iter, &val)) {
+ *error = errors::kInvalidChromeURLOverrides;
+ return false;
+ }
+ // Replace the entry with a fully qualified chrome-extension:// URL.
+ GURL url = GetResourceURL(val);
+ overrides->SetString(*iter, url.spec());
+ ++iter;
+ }
+ chrome_url_overrides_.reset(
+ static_cast<DictionaryValue*>(overrides->DeepCopy()));
+ }
+
return true;
}