diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 08:46:45 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 08:46:45 +0000 |
| commit | 007b3f812fc9c989fb99d4a668d8bd9c7807ad81 (patch) | |
| tree | 43e69dd0f4e4dbbe68afb6319fa18cee07a4be64 /chrome/common/extensions/extension_icon_set_unittest.cc | |
| parent | 2bde7e94eb8f402839145e48924391a5c645a554 (diff) | |
| download | chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.zip chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.gz chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.bz2 | |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/extension_icon_set_unittest.cc')
| -rw-r--r-- | chrome/common/extensions/extension_icon_set_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/common/extensions/extension_icon_set_unittest.cc b/chrome/common/extensions/extension_icon_set_unittest.cc index 1202cda..c7300a7 100644 --- a/chrome/common/extensions/extension_icon_set_unittest.cc +++ b/chrome/common/extensions/extension_icon_set_unittest.cc @@ -62,7 +62,7 @@ TEST(ExtensionIconSet, Values) { EXPECT_TRUE(icons.ContainsPath("foo")); EXPECT_TRUE(icons.ContainsPath("bar")); EXPECT_FALSE(icons.ContainsPath("baz")); - EXPECT_FALSE(icons.ContainsPath("")); + EXPECT_FALSE(icons.ContainsPath(std::string())); icons.Clear(); EXPECT_FALSE(icons.ContainsPath("foo")); @@ -83,7 +83,7 @@ TEST(ExtensionIconSet, FindSize) { EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, icons.GetIconSizeFromPath("baz")); EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, - icons.GetIconSizeFromPath("")); + icons.GetIconSizeFromPath(std::string())); icons.Clear(); EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, |