summaryrefslogtreecommitdiffstats
path: root/chrome/common/extensions/user_script_unittest.cc
diff options
context:
space:
mode:
authorskerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-04 21:25:31 +0000
committerskerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-04 21:25:31 +0000
commit542258c2719723200e46a45fdd7dc571ed5b90cf (patch)
tree5a7754d98ef347c17328696e62ec93bde6738d89 /chrome/common/extensions/user_script_unittest.cc
parent7b1c0376a17429471d2163c31ed4dbb05a9e819f (diff)
downloadchromium_src-542258c2719723200e46a45fdd7dc571ed5b90cf.zip
chromium_src-542258c2719723200e46a45fdd7dc571ed5b90cf.tar.gz
chromium_src-542258c2719723200e46a45fdd7dc571ed5b90cf.tar.bz2
Give a helpful warning message if a url patern contains a port.
BUG=32160 TEST=ExtensionURLPatternTest.Ports,ExtensionManifestTest.* Review URL: http://codereview.chromium.org/2835034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76967 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/user_script_unittest.cc')
-rw-r--r--chrome/common/extensions/user_script_unittest.cc12
1 files changed, 8 insertions, 4 deletions
diff --git a/chrome/common/extensions/user_script_unittest.cc b/chrome/common/extensions/user_script_unittest.cc
index 297de7b..bec6436 100644
--- a/chrome/common/extensions/user_script_unittest.cc
+++ b/chrome/common/extensions/user_script_unittest.cc
@@ -71,7 +71,8 @@ TEST(ExtensionUserScriptTest, Match5) {
TEST(ExtensionUserScriptTest, Match6) {
URLPattern pattern(kAllSchemes);
- ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern.Parse("http://*/foo*"));
+ ASSERT_EQ(URLPattern::PARSE_SUCCESS,
+ pattern.Parse("http://*/foo*", URLPattern::PARSE_STRICT));
UserScript script;
script.add_url_pattern(pattern);
@@ -87,7 +88,8 @@ TEST(ExtensionUserScriptTest, UrlPatternGlobInteraction) {
URLPattern pattern(kAllSchemes);
ASSERT_EQ(URLPattern::PARSE_SUCCESS,
- pattern.Parse("http://www.google.com/*"));
+ pattern.Parse("http://www.google.com/*",
+ URLPattern::PARSE_STRICT));
script.add_url_pattern(pattern);
script.add_glob("*bar*");
@@ -115,8 +117,10 @@ TEST(ExtensionUserScriptTest, UrlPatternGlobInteraction) {
TEST(ExtensionUserScriptTest, Pickle) {
URLPattern pattern1(kAllSchemes);
URLPattern pattern2(kAllSchemes);
- ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern1.Parse("http://*/foo*"));
- ASSERT_EQ(URLPattern::PARSE_SUCCESS, pattern2.Parse("http://bar/baz*"));
+ ASSERT_EQ(URLPattern::PARSE_SUCCESS,
+ pattern1.Parse("http://*/foo*", URLPattern::PARSE_STRICT));
+ ASSERT_EQ(URLPattern::PARSE_SUCCESS,
+ pattern2.Parse("http://bar/baz*", URLPattern::PARSE_STRICT));
UserScript script1;
script1.js_scripts().push_back(UserScript::File(