diff options
author | arv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 00:40:40 +0000 |
---|---|---|
committer | arv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-03 00:40:40 +0000 |
commit | 6404197b5dcbd4ac5e756d74c00c5eaf9f1d2870 (patch) | |
tree | 705851af6128b9c6d0d38ac5bf865828ce51483d /chrome/common/extensions | |
parent | 3774606e17a53662a3bd512f9fc6b5bb0946e675 (diff) | |
download | chromium_src-6404197b5dcbd4ac5e756d74c00c5eaf9f1d2870.zip chromium_src-6404197b5dcbd4ac5e756d74c00c5eaf9f1d2870.tar.gz chromium_src-6404197b5dcbd4ac5e756d74c00c5eaf9f1d2870.tar.bz2 |
Add command line option to use a tabbed bookmark manager.
Start with --enable-tabbed-bookmark-manager. This will show chrome://bookmarks in a tab instead of the old bookmark manager. However, to get the bookmark manager extension to show you need to use --load-extension=path_to_extension. The extension uses the chrome_url_override to show the extension instead of the bookmark manager.
BUG=4890
TEST=See description
Review URL: http://codereview.chromium.org/661019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40468 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions')
-rw-r--r-- | chrome/common/extensions/extension.cc | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc index 39929f7..0130929 100644 --- a/chrome/common/extensions/extension.cc +++ b/chrome/common/extensions/extension.cc @@ -64,7 +64,11 @@ static bool IsAPIPermission(const std::string& str) { if (str == Extension::kPermissionNames[i]) { if (str == Extension::kExperimentalPermission && !CommandLine::ForCurrentProcess()->HasSwitch( - switches::kEnableExperimentalExtensionApis)) { + switches::kEnableExperimentalExtensionApis) && + // TODO(arv): Tighten this so that not all extensions can access the + // experimental APIs. + !CommandLine::ForCurrentProcess()->HasSwitch( + switches::kEnableTabbedBookmarkManager)) { return false; } return true; @@ -1284,7 +1288,8 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_id, // this check, but let's keep it simple for now. // TODO(erikkay) enable other pages as well std::string val; - if ((page != chrome::kChromeUINewTabHost) || + if ((page != chrome::kChromeUINewTabHost && + page != chrome::kChromeUIBookmarksHost) || !overrides->GetStringWithoutPathExpansion(*iter, &val)) { *error = errors::kInvalidChromeURLOverrides; return false; |