Assert that thread-safe reference counting is used with

cross-thread NewRunnableMethod.

This assertion caught such an error in VisitedLinkMaster!

My approach, modify RunnableMethodTraits<T> to assert that
when ReleaseCallee happens on a different thread from
RetainCallee that the type supports thread-safe reference
counting.  I do this by adding a static method to both
RefCounted<T> and RefCountedThreadSafe<T>.

This results in a little ugliness in cases where people
implement AddRef and Release by hand (to make the no-ops).
There may be a nicer way to deal with those few cases.

R=brettw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/251012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 2 deletions

diff --git a/chrome/common/extensions/extension_error_reporter.cc b/chrome/common/extensions/extension_error_reporter.cc
index f6f0917..493b1a3 100644
--- a/chrome/common/extensions/extension_error_reporter.cc
+++ b/chrome/common/extensions/extension_error_reporter.cc
@@ -21,8 +21,8 @@
 // This is okay since the ExtensionErrorReporter is a singleton that lives until
 // the end of the process.
 template <> struct RunnableMethodTraits<ExtensionErrorReporter> {
-  static void RetainCallee(ExtensionErrorReporter*) {}
-  static void ReleaseCallee(ExtensionErrorReporter*) {}
+  void RetainCallee(ExtensionErrorReporter*) {}
+  void ReleaseCallee(ExtensionErrorReporter*) {}
 };
 
 ExtensionErrorReporter* ExtensionErrorReporter::instance_ = NULL;