summaryrefslogtreecommitdiffstats
path: root/chrome/common/gfx
diff options
context:
space:
mode:
authordkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-14 16:44:24 +0000
committerdkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-14 16:44:24 +0000
commitfb62884c4a51b06d6f36fff2ad6e1e1dc3f26235 (patch)
tree7d9a617d29a1ba896e7e8a622d079a134655a371 /chrome/common/gfx
parentd7e0fc871800e4cf6d94b168eb7f5b359903f2fd (diff)
downloadchromium_src-fb62884c4a51b06d6f36fff2ad6e1e1dc3f26235.zip
chromium_src-fb62884c4a51b06d6f36fff2ad6e1e1dc3f26235.tar.gz
chromium_src-fb62884c4a51b06d6f36fff2ad6e1e1dc3f26235.tar.bz2
Fix refcounting bug in ChromeFont's default constructor.
Found via valgrind. This was originally http://codereview.chromium.org/47001 but was rolled back due to possibly unrelated build breakage. Review URL: http://codereview.chromium.org/42205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11702 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/gfx')
-rw-r--r--chrome/common/gfx/chrome_font_skia.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/common/gfx/chrome_font_skia.cc b/chrome/common/gfx/chrome_font_skia.cc
index bd83a61..c77b5b9 100644
--- a/chrome/common/gfx/chrome_font_skia.cc
+++ b/chrome/common/gfx/chrome_font_skia.cc
@@ -58,6 +58,7 @@ void ChromeFont::calculateMetrics() {
void ChromeFont::CopyChromeFont(const ChromeFont& other) {
typeface_helper_.reset(new SkAutoUnref(other.typeface_));
typeface_ = other.typeface_;
+ typeface_->ref();
font_name_ = other.font_name_;
font_size_ = other.font_size_;
style_ = other.style_;