diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-08 20:04:48 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-08 20:04:48 +0000 |
| commit | 1bcea6d823e406bd37694c1f70e04cc72c2bbd28 (patch) | |
| tree | 3bf09724b783b1054f8789d2319d3f81594bf2ad /chrome/common/important_file_writer.cc | |
| parent | 38623ff26898ea65a5200f1cb4b063dd36d541cf (diff) | |
| download | chromium_src-1bcea6d823e406bd37694c1f70e04cc72c2bbd28.zip chromium_src-1bcea6d823e406bd37694c1f70e04cc72c2bbd28.tar.gz chromium_src-1bcea6d823e406bd37694c1f70e04cc72c2bbd28.tar.bz2 | |
Pull back some CHECK calls which were removed.
Original CL http://codereview.chromium.org/8368018/ was sort of
aggressive in some areas. I reveiewed it and this pulls back the
cases I'm pretty sure should be kept. My basic approach was to keep
things which would probably never happen in development, and which
signal a problem which is unlikely to be transient.
- important_file_writer.cc getting impossible amounts of data.
- cfbundle_blocker.mm logs blocked bundles so user can see.
- objc_zombie.mm crashes if the objc runtime is unexpectedly bizarre.
- multi-process lock logs failure.
I've actually seen that last before when a test nested a profile too
deeply, in which case knowing the filename was the key hint.
Review URL: http://codereview.chromium.org/8477018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109080 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/important_file_writer.cc')
| -rw-r--r-- | chrome/common/important_file_writer.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/common/important_file_writer.cc b/chrome/common/important_file_writer.cc index c5e4cf8..bd02f87 100644 --- a/chrome/common/important_file_writer.cc +++ b/chrome/common/important_file_writer.cc @@ -50,7 +50,8 @@ class WriteToDiskTask : public Task { return; } - DCHECK_LE(data_.length(), static_cast<size_t>(kint32max)); + // If this happens in the wild something really bad is going on. + CHECK_LE(data_.length(), static_cast<size_t>(kint32max)); int bytes_written = base::WritePlatformFile( tmp_file, 0, data_.data(), static_cast<int>(data_.length())); base::FlushPlatformFile(tmp_file); // Ignore return value. |