diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-24 19:21:13 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-24 19:21:13 +0000 |
| commit | 3cdb7af81de506be730544edcfe4a5547f0fdaea (patch) | |
| tree | 223c1e000b0eccf637565345904fb4055e41c5ea /chrome/common/ipc_sync_message.h | |
| parent | 8947da6c7cd943bcb4be80a258e263a84aa15006 (diff) | |
| download | chromium_src-3cdb7af81de506be730544edcfe4a5547f0fdaea.zip chromium_src-3cdb7af81de506be730544edcfe4a5547f0fdaea.tar.gz chromium_src-3cdb7af81de506be730544edcfe4a5547f0fdaea.tar.bz2 | |
Make IPC::SyncChannel not duplicate the underlying MessageLoop implementation by pumping messages on its own. This fixes the problem of windowless plugins not painting on right click, and generally makes this class almost ported, other than using a generic version of events/locks.Through this change I've also cleaned up the class and hopefully made it more understandable.
Review URL: http://codereview.chromium.org/8001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3934 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/ipc_sync_message.h')
| -rw-r--r-- | chrome/common/ipc_sync_message.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/common/ipc_sync_message.h b/chrome/common/ipc_sync_message.h index d098a99..86cb62f 100644 --- a/chrome/common/ipc_sync_message.h +++ b/chrome/common/ipc_sync_message.h @@ -27,8 +27,9 @@ class SyncMessage : public Message { // If this message can cause the receiver to block while waiting for user // input (i.e. by calling MessageBox), then the caller needs to pump window // messages and dispatch asynchronous messages while waiting for the reply. - // If this handle is passed in, then window messages will be pumped while - // it's set. The handle must be valid until after the Send call returns. + // If this handle is passed in, then window messages will start being pumped + // when it's set. Note that this behavior will continue even if the event is + // later reset. The handle must be valid until after the Send call returns. void set_pump_messages_event(HANDLE event) { pump_messages_event_ = event; if (event) { |