diff options
| author | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 09:49:11 +0000 |
|---|---|---|
| committer | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 09:49:11 +0000 |
| commit | acd78969cf6569dcbf409dceb0b6511751afd026 (patch) | |
| tree | ed2168c663ae3e8a15d857838b78ed2386da3281 /chrome/common/json_pref_store.h | |
| parent | 5138bbffd1b2d5151ad74b4e7ae8091fc7d44114 (diff) | |
| download | chromium_src-acd78969cf6569dcbf409dceb0b6511751afd026.zip chromium_src-acd78969cf6569dcbf409dceb0b6511751afd026.tar.gz chromium_src-acd78969cf6569dcbf409dceb0b6511751afd026.tar.bz2 | |
Clean up pref change notification handling.
This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically:
- Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore.
- Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore.
- Clean up related unit tests, removing redundant mocks and gmockify others.
BUG=64893
TEST=Compiles and passes tests
Review URL: http://codereview.chromium.org/5441002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/json_pref_store.h')
| -rw-r--r-- | chrome/common/json_pref_store.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/common/json_pref_store.h b/chrome/common/json_pref_store.h index 0407d1e..44f5c8c 100644 --- a/chrome/common/json_pref_store.h +++ b/chrome/common/json_pref_store.h @@ -29,7 +29,7 @@ class JsonPrefStore : public PrefStore, virtual ~JsonPrefStore(); // PrefStore methods: - virtual bool ReadOnly() { return read_only_; } + virtual bool ReadOnly() const { return read_only_; } virtual DictionaryValue* prefs() const { return prefs_.get(); } |