diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-03 22:15:53 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-03 22:15:53 +0000 |
| commit | 9674a8d040fc433b6282dc136b126396936a97a0 (patch) | |
| tree | 84d9856a95fbcda87f9430b14ec90e053d9629eb /chrome/common/mac | |
| parent | d5949313aa2372ca790bc33c3c6da3832a98cede (diff) | |
| download | chromium_src-9674a8d040fc433b6282dc136b126396936a97a0.zip chromium_src-9674a8d040fc433b6282dc136b126396936a97a0.tar.gz chromium_src-9674a8d040fc433b6282dc136b126396936a97a0.tar.bz2 | |
Revert 167021, info lead to bug-fix.
> [Mac] Temporarily stop clearing zombie objects.
>
> Zombie objects are cleared to '!' to force faster failure. The bug
> involves a containing object being zombied, and then trying to message
> something it owns. This change will provide info on the object being
> messaged, and perhaps info on who deallocated it.
>
> BUG=154483
>
>
> Review URL: https://chromiumcodereview.appspot.com/11359117
TBR=shess@chromium.org
Review URL: https://codereview.chromium.org/11428147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170825 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/mac')
| -rw-r--r-- | chrome/common/mac/objc_zombie.mm | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/common/mac/objc_zombie.mm b/chrome/common/mac/objc_zombie.mm index cd6a31a..0f01a52 100644 --- a/chrome/common/mac/objc_zombie.mm +++ b/chrome/common/mac/objc_zombie.mm @@ -116,11 +116,7 @@ void ZombieDealloc(id self, SEL _cmd) { // class without C++ destructors or associative references, so it // won't hurt anything. objc_destructInstance(self); - // TODO(shess): Temporarily disable clearing the object to debug - // http://crbug.com/154483 -#if 0 memset(self, '!', size); -#endif // If the instance is big enough, make it into a fat zombie and have // it remember the old |isa|. Otherwise make it a regular zombie. |