Omnibox: Have UMA Log Interactions Even When Dropdown is Closed

Adds two omnibox proto fields to describe the state
of this dropdown-closed interaction.

AutocompleteActionPredictor predictor is meant to
change relatively little; I think the current code is a
slight improvement.

RLZ RecordFirstSearch() triggering is exactly the same as before.

The histogram name change is because this histogram will
be recorded under different conditions than before.
Hence, I also updated histograms.xml.

Omnibox.EventCount is a non-UMA histogram, so doesn't
need to have its name changed and does not appear
in histograms.xml.

TBR=dominich

BUG=264992

Review URL: https://codereview.chromium.org/149513008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267411 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 14 insertions, 1 deletions

diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto
index f94c63d..a630973 100644
--- a/chrome/common/metrics/proto/omnibox_event.proto
+++ b/chrome/common/metrics/proto/omnibox_event.proto
@@ -10,7 +10,7 @@ option optimize_for = LITE_RUNTIME;
 
 package metrics;
 
-// Next tag: 15
+// Next tag: 17
 message OmniboxEventProto {
   // The timestamp for the event, in seconds since the epoch.
   optional int64 time = 1;
@@ -39,6 +39,19 @@ message OmniboxEventProto {
   // dropdown.
   optional bool is_top_result_hidden_in_dropdown = 14;
 
+  // Whether the omnibox popup is open.  It can be closed if, for instance,
+  // the user clicks in the omnibox and hits return to reload the same page.
+  // If the popup is closed, the suggestion list will contain only one item
+  // and selected_index will be 0 (pointing to that single item).  Because
+  // paste-and-search/paste-and-go actions ignore the current content of the
+  // omnibox dropdown (if it is open) when they happen, we pretend the
+  // dropdown is closed when logging these.
+  optional bool is_popup_open = 15;
+
+  // True if this is a paste-and-search or paste-and-go action.  (The codebase
+  // refers to both these types as paste-and-go.)
+  optional bool is_paste_and_go = 16;
+
   // The length of the inline autocomplete text in the omnibox.
   // The sum |typed_length| + |completed_length| gives the full length of the
   // user-visible text in the omnibox.