diff options
author | mpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-15 23:01:51 +0000 |
---|---|---|
committer | mpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-15 23:01:51 +0000 |
commit | 0e9e87823285d504a210dcce2eabdc847f230f09 (patch) | |
tree | c83e9fcd59553e2e5317edab0cecbdb1f5799bf2 /chrome/common/metrics | |
parent | ace4a123275eba3934dc1b1b7c2d8dc859d2e07a (diff) | |
download | chromium_src-0e9e87823285d504a210dcce2eabdc847f230f09.zip chromium_src-0e9e87823285d504a210dcce2eabdc847f230f09.tar.gz chromium_src-0e9e87823285d504a210dcce2eabdc847f230f09.tar.bz2 |
Adds per-provider information to omnibox UMA logs.
Adds a fairly general structure to omnibox logs that can be used to pass information (that's not per-result information) from providers to the UMA logs. Right now it's only used to pass whether the asynchronous pass of a provider has finished, but it will probably be used for other things in the future.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10380007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137288 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/metrics')
-rw-r--r-- | chrome/common/metrics/proto/omnibox_event.proto | 43 |
1 files changed, 30 insertions, 13 deletions
diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto index c11eade..a46c287 100644 --- a/chrome/common/metrics/proto/omnibox_event.proto +++ b/chrome/common/metrics/proto/omnibox_event.proto @@ -10,7 +10,7 @@ option optimize_for = LITE_RUNTIME; package metrics; -// Next tag: 12 +// Next tag: 13 message OmniboxEventProto { // The timestamp for the event, in seconds since the epoch. optional int64 time = 1; @@ -73,21 +73,23 @@ message OmniboxEventProto { } optional InputType input_type = 8; + // An enum used in multiple places below. + enum ProviderType { + UNKNOWN_PROVIDER = 0; // Unknown provider (should not reach here) + HISTORY_URL = 1; // URLs in history, or user-typed URLs + HISTORY_CONTENTS = 2; // Matches for page contents of pages in history + HISTORY_QUICK = 3; // Matches for recently or frequently visited pages + // in history + SEARCH = 4; // Search suggestions for the default search engine + KEYWORD = 5; // Keyword-triggered searches + BUILTIN = 6; // Built-in URLs, such as chrome://version + SHORTCUTS = 7; // Recently selected omnibox suggestions + EXTENSION_APPS = 8; // Custom suggestions from extensions and/or apps + } + // The result set displayed on the completion popup message Suggestion { // Where does this result come from? - enum ProviderType { - UNKNOWN_PROVIDER = 0; // Unknown provider (should not reach here) - URL = 1; // URLs in history, or user-typed URLs - HISTORY_CONTENTS = 2; // Matches for page contents of pages in history - HISTORY_QUICK = 3; // Matches for recently or frequently visited pages - // in history - SEARCH = 4; // Search suggestions for the default search engine - KEYWORD = 5; // Keyword-triggered searches - BUILTIN = 6; // Built-in URLs, such as chrome://version - SHORTCUTS = 7; // Recently selected omnibox suggestions - EXTENSION_APPS = 8; // Custom suggestions from extensions and/or apps - } optional ProviderType provider = 1; // What kind of result this is. @@ -121,4 +123,19 @@ message OmniboxEventProto { optional bool is_starred = 4; } repeated Suggestion suggestion = 9; + + // A data structure that holds per-provider information, general information + // not associated with a particular result. + message ProviderInfo { + // Which provider generated this ProviderInfo entry. + optional ProviderType provider = 1; + + // The provider's done() value, i.e., whether it's completed processing + // the query. Providers which don't do any asynchronous processing + // will always be done. + optional bool provider_done = 2; + } + // A list of diagnostic information about each provider. Providers + // will appear at most once in this list. + repeated ProviderInfo provider_info = 12; } |