summaryrefslogtreecommitdiffstats
path: root/chrome/common/metrics_helpers.cc
diff options
context:
space:
mode:
authorziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-10 00:31:27 +0000
committerziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-10 00:31:27 +0000
commit24d07e35d01b64462fc8b68b048097c5d276f479 (patch)
treee91c995554363a66c501e0316acdee06b6d4cc62 /chrome/common/metrics_helpers.cc
parent7658fb22bc5090a3b22be8f50702d852f4d50ea2 (diff)
downloadchromium_src-24d07e35d01b64462fc8b68b048097c5d276f479.zip
chromium_src-24d07e35d01b64462fc8b68b048097c5d276f479.tar.gz
chromium_src-24d07e35d01b64462fc8b68b048097c5d276f479.tar.bz2
Removed some unused code. We were adding some data to std::set objects that never get read from again.
r=jar Review URL: http://codereview.chromium.org/2925006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52026 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/metrics_helpers.cc')
-rw-r--r--chrome/common/metrics_helpers.cc12
1 files changed, 5 insertions, 7 deletions
diff --git a/chrome/common/metrics_helpers.cc b/chrome/common/metrics_helpers.cc
index 68f9083..6008c66 100644
--- a/chrome/common/metrics_helpers.cc
+++ b/chrome/common/metrics_helpers.cc
@@ -380,8 +380,9 @@ int64 MetricsLogBase::GetBuildTime() {
// Internal state is being needlessly exposed, and it would be hard to reuse
// this code. If we moved this into the Histogram class, then we could use
// the same infrastructure for logging StatsCounters, RatesCounters, etc.
-void MetricsLogBase::RecordHistogramDelta(const Histogram& histogram,
- const Histogram::SampleSet& snapshot) {
+void MetricsLogBase::RecordHistogramDelta(
+ const Histogram& histogram,
+ const Histogram::SampleSet& snapshot) {
DCHECK(!locked_);
DCHECK_NE(0, snapshot.TotalCount());
snapshot.CheckSize(histogram);
@@ -469,13 +470,10 @@ void MetricsServiceBase::RecordCurrentHistograms() {
StatisticsRecorder::Histograms histograms;
StatisticsRecorder::GetHistograms(&histograms);
- for (StatisticsRecorder::Histograms::iterator it = histograms.begin();
+ for (StatisticsRecorder::Histograms::const_iterator it = histograms.begin();
histograms.end() != it;
++it) {
if ((*it)->flags() & Histogram::kUmaTargetedHistogramFlag)
- // TODO(petersont): Only record historgrams if they are not precluded by
- // the UMA response data.
- // Bug http://code.google.com/p/chromium/issues/detail?id=2739.
RecordHistogram(**it);
}
}
@@ -500,7 +498,7 @@ void MetricsServiceBase::RecordHistogram(const Histogram& histogram) {
snapshot.Subtract(*already_logged);
}
- // snapshot now contains only a delta to what we've already_logged.
+ // Snapshot now contains only a delta to what we've already_logged.
if (snapshot.TotalCount() > 0) {
current_log_->RecordHistogramDelta(histogram, snapshot);