diff options
| author | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-29 23:04:57 +0000 |
|---|---|---|
| committer | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-29 23:04:57 +0000 |
| commit | fa7ebe0b9d7e66187b5981715cc3905ebd048767 (patch) | |
| tree | bc3a42713bbf03c2e47e8a8979bfd009cc3db9fc /chrome/common/metrics_helpers.cc | |
| parent | 002ae4222e36f23ee1eb13e72d04e916571a36b6 (diff) | |
| download | chromium_src-fa7ebe0b9d7e66187b5981715cc3905ebd048767.zip chromium_src-fa7ebe0b9d7e66187b5981715cc3905ebd048767.tar.gz chromium_src-fa7ebe0b9d7e66187b5981715cc3905ebd048767.tar.bz2 | |
Fix for not instantiating a new page on singleton tabs when the tab is already
open and bug fix for when feedback tab is closed without hitting cancel
(hitting cancel, cancels any pending system information requests, which was
being skipped when the cancel button wasn't hit and the tab was directly closed)
When Navigate is called for a Singleton tabs, regardless of whether or not the
tab is already open, by default navigate creates tab_contents for the URL and
then checks if the URL is already open on another tab - this can causes issues
with DOM UI pages which expect to be open only at one time on one browser; in
this case, the feedback DOM UI.
BUG=chromium-os:8857
TEST=Ran multiple browsers and clicked on the feedback button while the feedback
page was open - from the feedback page itself, and from other pages. Correct
behavior was observed; we switched to the feedback page and no crashes.
Review URL: http://codereview.chromium.org/4921001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67606 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/metrics_helpers.cc')
0 files changed, 0 insertions, 0 deletions