diff options
| author | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 00:13:00 +0000 |
|---|---|---|
| committer | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 00:13:00 +0000 |
| commit | 1f82b3d181c2e5c87670645f1f298532ca813956 (patch) | |
| tree | dad5003d8c7be671d472e56d80aeb20d9eeb97df /chrome/common/net | |
| parent | 7f4ad940481637e20452bc763d83717c7aaa72d3 (diff) | |
| download | chromium_src-1f82b3d181c2e5c87670645f1f298532ca813956.zip chromium_src-1f82b3d181c2e5c87670645f1f298532ca813956.tar.gz chromium_src-1f82b3d181c2e5c87670645f1f298532ca813956.tar.bz2 | |
Don't attempt to forward declare StringPiece.
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/8820016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114124 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/net')
| -rw-r--r-- | chrome/common/net/net_resource_provider.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/common/net/net_resource_provider.h b/chrome/common/net/net_resource_provider.h index c577075..cebb3df 100644 --- a/chrome/common/net/net_resource_provider.h +++ b/chrome/common/net/net_resource_provider.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,9 +6,7 @@ #define CHROME_COMMON_NET_NET_RESOURCE_PROVIDER_H_ #pragma once -namespace base { -class StringPiece; -} +#include "base/string_piece.h" namespace chrome_common_net { |