diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 23:42:43 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 23:42:43 +0000 |
| commit | 8e4f010318e8ee028b22a2e8f5d4276a93054950 (patch) | |
| tree | e0eee580f0f66dce4f55e45efdc0a76dcb1ac26b /chrome/common/net | |
| parent | 9a9787ed17dce85531063d1fb2a07ce801c58de5 (diff) | |
| download | chromium_src-8e4f010318e8ee028b22a2e8f5d4276a93054950.zip chromium_src-8e4f010318e8ee028b22a2e8f5d4276a93054950.tar.gz chromium_src-8e4f010318e8ee028b22a2e8f5d4276a93054950.tar.bz2 | |
Add undeclared virtual destructors part 4
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54408 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/net')
| -rw-r--r-- | chrome/common/net/url_fetcher.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/common/net/url_fetcher.h b/chrome/common/net/url_fetcher.h index 4671ae0..79234ca 100644 --- a/chrome/common/net/url_fetcher.h +++ b/chrome/common/net/url_fetcher.h @@ -74,6 +74,9 @@ class URLFetcher { int response_code, const ResponseCookies& cookies, const std::string& data) = 0; + + protected: + virtual ~Delegate() {} }; // URLFetcher::Create uses the currently registered Factory to create the @@ -84,6 +87,9 @@ class URLFetcher { const GURL& url, RequestType request_type, Delegate* d) = 0; + + protected: + virtual ~Factory() {} }; // |url| is the URL to send the request to. |