diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
commit | 11f48572859aca238afeb436d2504c5ffab49f07 (patch) | |
tree | 1b31af349eb99a9e83716f5add3273b42bee41cf /chrome/common/notification_details.h | |
parent | af530ac147feb1b04446f529daa4cc4448f89b23 (diff) | |
download | chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.zip chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.gz chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.bz2 |
Fixes almost all of the rest of lint errors in the chrome/ directory (minus the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/notification_details.h')
-rw-r--r-- | chrome/common/notification_details.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/common/notification_details.h b/chrome/common/notification_details.h index ee10111..2c914d7 100644 --- a/chrome/common/notification_details.h +++ b/chrome/common/notification_details.h @@ -33,7 +33,7 @@ class NotificationDetails { } protected: - NotificationDetails(const void* ptr) : ptr_(ptr) {} + explicit NotificationDetails(const void* ptr) : ptr_(ptr) {} // Declaring this const allows Details<T> to be used with both T = Foo and // T = const Foo. @@ -43,8 +43,9 @@ class NotificationDetails { template <class T> class Details : public NotificationDetails { public: - Details(T* ptr) : NotificationDetails(ptr) {} - Details(const NotificationDetails& other) + // TODO(erg): Our code hard relies on implicit conversion + Details(T* ptr) : NotificationDetails(ptr) {} // NOLINT + Details(const NotificationDetails& other) // NOLINT : NotificationDetails(other) {} T* operator->() const { return ptr(); } |