Cleans up notifications for the NavigationController. There were several

notifications before and some of them were very unclear and misused
(STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases
as well.

I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more
clear and covers (I think!) all the cases that the callers care about.

I added a simple notification testing helper class, and used in the navigation
controller unit tests to make sure we get the proper notifications. I had to
change NotificationSource/Details to have a = and copy constructor so I can
track them easily in my helper. I don't see why this would be bad.

As part of this, I got very frustrated recompiling the world whenever
navigation_types.h changed. So I removed this dependency from the notification
service which everybody includes. Most of the changed files are adding
notification_types.h in the .cc file where it's needed.

BUG=1325636,1321376,1325779


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@956 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 4 deletions

diff --git a/chrome/common/notification_details.h b/chrome/common/notification_details.h
index 9c7fdff..31378c4 100644
--- a/chrome/common/notification_details.h
+++ b/chrome/common/notification_details.h
@@ -41,6 +41,7 @@
 class NotificationDetails {
  public:
   NotificationDetails() : ptr_(NULL) {}
+  NotificationDetails(const NotificationDetails& other) : ptr_(other.ptr_) {}
   ~NotificationDetails() {}
 
   // NotificationDetails can be used as the index for a map; this method
@@ -58,12 +59,8 @@ class NotificationDetails {
 
  protected:
   NotificationDetails(void* ptr) : ptr_(ptr) {}
-  NotificationDetails(const NotificationDetails& other) : ptr_(other.ptr_) {}
 
   void* ptr_;
-
-private:
-  void operator=(const NotificationDetails&);
 };
 
 template <class T>