diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-13 19:56:17 +0000 |
commit | 11f48572859aca238afeb436d2504c5ffab49f07 (patch) | |
tree | 1b31af349eb99a9e83716f5add3273b42bee41cf /chrome/common/notification_source.h | |
parent | af530ac147feb1b04446f529daa4cc4448f89b23 (diff) | |
download | chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.zip chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.gz chromium_src-11f48572859aca238afeb436d2504c5ffab49f07.tar.bz2 |
Fixes almost all of the rest of lint errors in the chrome/ directory (minus the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/notification_source.h')
-rw-r--r-- | chrome/common/notification_source.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/common/notification_source.h b/chrome/common/notification_source.h index fb37124..98b9f66 100644 --- a/chrome/common/notification_source.h +++ b/chrome/common/notification_source.h @@ -31,7 +31,7 @@ class NotificationSource { } protected: - NotificationSource(const void* ptr) : ptr_(ptr) {} + explicit NotificationSource(const void* ptr) : ptr_(ptr) {} // Declaring this const allows Source<T> to be used with both T = Foo and // T = const Foo. @@ -41,9 +41,9 @@ class NotificationSource { template <class T> class Source : public NotificationSource { public: - Source(T* ptr) : NotificationSource(ptr) {} - - Source(const NotificationSource& other) + // TODO(erg): Our code hard relies on implicit conversion + Source(T* ptr) : NotificationSource(ptr) {} // NOLINT + Source(const NotificationSource& other) // NOLINT : NotificationSource(other) {} T* operator->() const { return ptr(); } |