Cleans up notifications for the NavigationController. There were several

notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well.

I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about.

I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad.

BUG=1325636,1321376,1325779

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1039 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 4 deletions

diff --git a/chrome/common/notification_source.h b/chrome/common/notification_source.h
index 31077e9..049a12d 100644
--- a/chrome/common/notification_source.h
+++ b/chrome/common/notification_source.h
@@ -40,6 +40,7 @@
 // NotificationService::AllSources().
 class NotificationSource {
  public:
+  NotificationSource(const NotificationSource& other) : ptr_(other.ptr_) { }
   ~NotificationSource() {}
 
   // NotificationSource can be used as the index for a map; this method
@@ -56,12 +57,8 @@ class NotificationSource {
 
  protected:
   NotificationSource(void* ptr) : ptr_(ptr) {}
-  NotificationSource(const NotificationSource& other) : ptr_(other.ptr_) { }
 
   void* ptr_;
-
- private:
-  void operator=(const NotificationSource&);
 };
 
 template <class T>