summaryrefslogtreecommitdiffstats
path: root/chrome/common/plugin_messages.cc
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-04 03:15:58 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-04 03:15:58 +0000
commit39b7b06790a776ee2247f391b1b2e3af1a335503 (patch)
tree8813c8831c92e6f00e8e72bbeaa95693e695c683 /chrome/common/plugin_messages.cc
parentd718a62d075bdd6f45a128bd5d82358d73799300 (diff)
downloadchromium_src-39b7b06790a776ee2247f391b1b2e3af1a335503.zip
chromium_src-39b7b06790a776ee2247f391b1b2e3af1a335503.tar.gz
chromium_src-39b7b06790a776ee2247f391b1b2e3af1a335503.tar.bz2
Make it easier/less work/less error-prone to create new IPC channel types (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest
Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/plugin_messages.cc')
-rw-r--r--chrome/common/plugin_messages.cc23
1 files changed, 0 insertions, 23 deletions
diff --git a/chrome/common/plugin_messages.cc b/chrome/common/plugin_messages.cc
deleted file mode 100644
index cd5b00a..0000000
--- a/chrome/common/plugin_messages.cc
+++ /dev/null
@@ -1,23 +0,0 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/ipc_message.h"
-
-#ifdef IPC_MESSAGE_LOG_ENABLED
-
-#define IPC_MESSAGE_MACROS_LOG_ENABLED
-
-#endif // IPC_MESSAGE_LOG_ENABLED
-
-#include "chrome/common/plugin_messages.h"
-
-void PluginMessagesInit() {
-#ifdef IPC_MESSAGE_LOG_ENABLED
- IPC::RegisterMessageLogger(PluginProcessStart, PluginProcessMsgLog);
- IPC::RegisterMessageLogger(PluginProcessHostStart, PluginProcessHostMsgLog);
- IPC::RegisterMessageLogger(PluginStart, PluginMsgLog);
- IPC::RegisterMessageLogger(PluginHostStart, PluginHostMsgLog);
- IPC::RegisterMessageLogger(NPObjectStart, NPObjectMsgLog);
-#endif
-}