ImportantFileWriter

Introducing a class for writing important files, preventing their corruption during writing.

Switched PrefService to use it. Other classes will be switched in future changesets.

TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences.

http://crbug.com/10618

Review URL: http://codereview.chromium.org/83001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 3 deletions

diff --git a/chrome/common/pref_member_unittest.cc b/chrome/common/pref_member_unittest.cc
index 0e87978..7fe9c6d 100644
--- a/chrome/common/pref_member_unittest.cc
+++ b/chrome/common/pref_member_unittest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/file_path.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_member.h"
 #include "chrome/common/pref_service.h"
@@ -49,7 +50,7 @@ class PrefMemberTestClass : public NotificationObserver {
 }  // anonymous namespace
 
 TEST(PrefMemberTest, BasicGetAndSet) {
-  PrefService prefs;
+  PrefService prefs(FilePath(), NULL);
   RegisterTestPrefs(&prefs);
 
   // Test bool
@@ -139,7 +140,7 @@ TEST(PrefMemberTest, BasicGetAndSet) {
 
 TEST(PrefMemberTest, TwoPrefs) {
   // Make sure two RealPrefMembers stay in sync.
-  PrefService prefs;
+  PrefService prefs(FilePath(), NULL);
   RegisterTestPrefs(&prefs);
 
   RealPrefMember pref1;
@@ -159,7 +160,7 @@ TEST(PrefMemberTest, TwoPrefs) {
 }
 
 TEST(PrefMemberTest, Observer) {
-  PrefService prefs;
+  PrefService prefs(FilePath(), NULL);
   RegisterTestPrefs(&prefs);
 
   PrefMemberTestClass test_obj(&prefs);