diff options
author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
---|---|---|
committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
commit | 7f856bee73ffdccdbbbbbab4cb79185290d38359 (patch) | |
tree | a837328e08a113abdc70b2fc0ae2f2a4a3f804eb /chrome/common/pref_names.cc | |
parent | 281fe14063dd8fb81cea102f5abb7b82f407c3d1 (diff) | |
download | chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.zip chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.gz chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.bz2 |
First cut at the bookmark manager. There are still a fair number of
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:
. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.
I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.
BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
still works.
Review URL: http://codereview.chromium.org/8197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/pref_names.cc')
-rw-r--r-- | chrome/common/pref_names.cc | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc index 19b13b4..a83475e 100644 --- a/chrome/common/pref_names.cc +++ b/chrome/common/pref_names.cc @@ -202,9 +202,22 @@ const wchar_t kDeleteCookies[] = L"browser.clear_data.cookies"; const wchar_t kDeletePasswords[] = L"browser.clear_data.passwords"; const wchar_t kDeleteTimePeriod[] = L"browser.clear_data.time_period"; +// Integer prefs giving the widths of the columns in the bookmark table. Two +// configs are saved, one with the path column and one without. +const wchar_t kBookmarkTableNameWidth1[] = L"bookmark_table.name_width_1"; +const wchar_t kBookmarkTableURLWidth1[] = L"bookmark_table.url_width_1"; +const wchar_t kBookmarkTableNameWidth2[] = L"bookmark_table.name_width_2"; +const wchar_t kBookmarkTableURLWidth2[] = L"bookmark_table.url_width_2"; +const wchar_t kBookmarkTablePathWidth[] = L"bookmark_table.path_width"; + // Boolean pref to define the default values for using spellchecker. const wchar_t kEnableSpellCheck[] = L"browser.enable_spellchecking"; +// Bounds of the bookmark manager. +const wchar_t kBookmarkManagerPlacement[] = + L"bookmark_manager.window_placement"; + + // *************** LOCAL STATE *************** // These are attached to the machine/installation @@ -432,4 +445,3 @@ const wchar_t kNumFoldersInOtherBookmarkFolder[] = const wchar_t kNumKeywords[] = L"user_experience_metrics.num_keywords"; } // namespace prefs - |