diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
| commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
| tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /chrome/common/pref_names_util_unittest.cc | |
| parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
| download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 | |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/pref_names_util_unittest.cc')
| -rw-r--r-- | chrome/common/pref_names_util_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/common/pref_names_util_unittest.cc b/chrome/common/pref_names_util_unittest.cc index 2d1356a..9f215ea 100644 --- a/chrome/common/pref_names_util_unittest.cc +++ b/chrome/common/pref_names_util_unittest.cc @@ -28,7 +28,7 @@ void ExpectParse(const std::string& path, } // namespace TEST(PrefNamesUtilTest, Basic) { - ExpectNoParse(""); + ExpectNoParse(std::string()); ExpectNoParse("."); ExpectNoParse("....."); ExpectNoParse("webkit.webprefs.fonts."); @@ -43,8 +43,8 @@ TEST(PrefNamesUtilTest, Basic) { // We don't particularly care about the parsed family and script for these // inputs, but just want to make sure it does something reasonable. Returning // false may also be an option. - ExpectParse("webkit.webprefs.fonts...", "", "."); - ExpectParse("webkit.webprefs.fonts....", "", ".."); + ExpectParse("webkit.webprefs.fonts...", std::string(), "."); + ExpectParse("webkit.webprefs.fonts....", std::string(), ".."); // Check that passing NULL output params is okay. EXPECT_TRUE(pref_names_util::ParseFontNamePrefPath( |