diff options
| author | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-12 16:55:58 +0000 |
|---|---|---|
| committer | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-12 16:55:58 +0000 |
| commit | ddf90dc66f07c49f91d103f92cebcc489dfcf620 (patch) | |
| tree | a8b506ce423e7fd3f9b2b7bec2bf0da49e96a70d /chrome/common/print_messages.h | |
| parent | f12b5127bf168cb15f5cc3446f74c9743cc7e872 (diff) | |
| download | chromium_src-ddf90dc66f07c49f91d103f92cebcc489dfcf620.zip chromium_src-ddf90dc66f07c49f91d103f92cebcc489dfcf620.tar.gz chromium_src-ddf90dc66f07c49f91d103f92cebcc489dfcf620.tar.bz2 | |
Reland 96406 - Print preview page selection should not require a rerendering of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
Review URL: http://codereview.chromium.org/7544018
Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=96406
Revert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7628019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96567 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/print_messages.h')
| -rw-r--r-- | chrome/common/print_messages.h | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/chrome/common/print_messages.h b/chrome/common/print_messages.h index 618ece5..e9d24e3 100644 --- a/chrome/common/print_messages.h +++ b/chrome/common/print_messages.h @@ -187,11 +187,7 @@ IPC_MESSAGE_ROUTED0(PrintMsg_PrintForSystemDialog) IPC_MESSAGE_ROUTED0(PrintMsg_ResetScriptedPrintCount) // Tells a renderer to continue generating the print preview. -// Use |requested_preview_page_index| to request a specific preview page data. -// |requested_preview_page_index| is 1-based or |printing::INVALID_PAGE_INDEX| -// to render the next page. -IPC_MESSAGE_ROUTED1(PrintMsg_ContinuePreview, - int /* requested_preview_page_index */) +IPC_MESSAGE_ROUTED0(PrintMsg_ContinuePreview) // Tells a renderer to abort the print preview and reset all state. IPC_MESSAGE_ROUTED0(PrintMsg_AbortPreview) @@ -259,10 +255,11 @@ IPC_MESSAGE_CONTROL1(PrintHostMsg_TempFileForPrintingWritten, IPC_MESSAGE_ROUTED0(PrintHostMsg_RequestPrintPreview) // Notify the browser the number of pages in the print preview document. -IPC_MESSAGE_ROUTED3(PrintHostMsg_DidGetPreviewPageCount, +IPC_MESSAGE_ROUTED4(PrintHostMsg_DidGetPreviewPageCount, int /* document cookie */, int /* page count */, - bool /* is modifiable */) + bool /* is modifiable */, + bool /* clear all preview data */) // Notify the browser a print preview page has been rendered. IPC_MESSAGE_ROUTED1(PrintHostMsg_DidPreviewPage, @@ -271,7 +268,7 @@ IPC_MESSAGE_ROUTED1(PrintHostMsg_DidPreviewPage, // Sends back to the browser the complete rendered document for print preview // that was requested by a PrintMsg_PrintPreview message. The memory handle in // this message is already valid in the browser process. -IPC_MESSAGE_ROUTED1(PrintHostMsg_PagesReadyForPreview, +IPC_MESSAGE_ROUTED1(PrintHostMsg_MetafileReadyForPrinting, PrintHostMsg_DidPreviewDocument_Params /* params */) // Tell the browser printing failed. |