diff options
| author | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-14 15:42:43 +0000 |
|---|---|---|
| committer | brettw@google.com <brettw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-14 15:42:43 +0000 |
| commit | e9ba44740c88677d8b566583f7041d1dd33b6a9d (patch) | |
| tree | 0d85125a089ba6c36136a22651d196a9ba86ec8f /chrome/common/render_messages.h | |
| parent | b5ef2ca48635ddf96698a11676a4625aff6ef734 (diff) | |
| download | chromium_src-e9ba44740c88677d8b566583f7041d1dd33b6a9d.zip chromium_src-e9ba44740c88677d8b566583f7041d1dd33b6a9d.tar.gz chromium_src-e9ba44740c88677d8b566583f7041d1dd33b6a9d.tar.bz2 | |
This is almost a complete rewrite of DidNavigate and the associated NavigationController logic. The approach is that the NavigationController should be responsible for the logic and memory management of navigation. Previously, half the logic and memory management lived in WebContents which made it very hard to figure out what was going on.
I split out the various navigation types into separate functions, which then copy and update any existing NavigationEntry as necessary. Previously, WebContents would make a new one which would be manually populated with random fields (I think some were forgotten, too), and then the NavigationController may or may not commit it.
Review URL: http://codereview.chromium.org/479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2201 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/render_messages.h')
| -rw-r--r-- | chrome/common/render_messages.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h index e39b392e..6f82feb 100644 --- a/chrome/common/render_messages.h +++ b/chrome/common/render_messages.h @@ -61,11 +61,11 @@ struct ViewHostMsg_FrameNavigate_Params { // iframes are loaded automatically. int32 page_id; - // URL of the page being loaded. NON-CANONICAL. + // URL of the page being loaded. GURL url; // URL of the referrer of this load. WebKit generates this based on the - // source of the event that caused the load. NON-CANONICAL. + // source of the event that caused the load. GURL referrer; // The type of transition. |