diff options
| author | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-06 07:40:53 +0000 |
|---|---|---|
| committer | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-06 07:40:53 +0000 |
| commit | 34f6bc1937fe617875e8f5e95485904569cca582 (patch) | |
| tree | 94f201b6bb78ff601a8a97783f4ac0134423af48 /chrome/common/render_messages_internal.h | |
| parent | 576d8bff4e6778c6de60b8a7269a78c5e8bf602a (diff) | |
| download | chromium_src-34f6bc1937fe617875e8f5e95485904569cca582.zip chromium_src-34f6bc1937fe617875e8f5e95485904569cca582.tar.gz chromium_src-34f6bc1937fe617875e8f5e95485904569cca582.tar.bz2 | |
Changes parameters used by IME code to fix several issues caused by Japanese IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/render_messages_internal.h')
| -rw-r--r-- | chrome/common/render_messages_internal.h | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h index 4e6643c..a4098a0 100644 --- a/chrome/common/render_messages_internal.h +++ b/chrome/common/render_messages_internal.h @@ -890,8 +890,8 @@ IPC_BEGIN_MESSAGES(ViewHost, 2) // - Notifying a renderer process moves its input focus from a // password input to an editable control which is NOT a password // input. - // A renderer process also has to set caret_x and caret_y and - // specify the new caret position. + // A renderer process also has to set caret_rect and + // specify the new caret rectangle. // + IME_COMPLETE_COMPOSITION // Finish the current composition. // This code is used for notifying a renderer process moves its @@ -899,13 +899,11 @@ IPC_BEGIN_MESSAGES(ViewHost, 2) // which is NOT a password input. A browser process closes its IME // windows without changing the activation status of its IME, i.e. it // keeps activating its IME. - // * caret_x (int) - // * caret_y (int) - // They specify the position of the input caret. - IPC_MESSAGE_ROUTED3(ViewHostMsg_ImeUpdateStatus, + // * caret_rect (gfx::Rect) + // They specify the rectangle of the input caret. + IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeUpdateStatus, ViewHostMsg_ImeControl, /* control */ - int, /* caret_x */ - int /* caret_y */) + gfx::Rect /* caret_rect */) // Response for InspectElement request. Returns the number of resources // identified by InspectorController. |