diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-15 17:05:46 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-15 17:05:46 +0000 |
| commit | ba9daa6c087fb6320f32f47561b2d06a4c04c41b (patch) | |
| tree | 6a6abd8e2ba2e0f91a1fe0f0656ed7c2639eb140 /chrome/common/render_messages_internal.h | |
| parent | 01938c95315cec08d8bfed833e02374626ee9961 (diff) | |
| download | chromium_src-ba9daa6c087fb6320f32f47561b2d06a4c04c41b.zip chromium_src-ba9daa6c087fb6320f32f47561b2d06a4c04c41b.tar.gz chromium_src-ba9daa6c087fb6320f32f47561b2d06a4c04c41b.tar.bz2 | |
3rd attempt at landing the language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/518075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/render_messages_internal.h')
| -rw-r--r-- | chrome/common/render_messages_internal.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h index 2003c9d..a45310d 100644 --- a/chrome/common/render_messages_internal.h +++ b/chrome/common/render_messages_internal.h @@ -255,9 +255,6 @@ IPC_BEGIN_MESSAGES(View) string16 /* search_text */, WebKit::WebFindOptions) - // Asks the renderer for the language of the current page. - IPC_MESSAGE_ROUTED0(ViewMsg_DeterminePageLanguage) - // Send from the renderer to the browser to return the script running result. IPC_MESSAGE_ROUTED2(ViewMsg_ExecuteCodeFinished, int, /* request id */ @@ -1118,7 +1115,7 @@ IPC_BEGIN_MESSAGES(ViewHost) IPC_MESSAGE_ROUTED1(ViewHostMsg_UpdateSpellingPanelWithMisspelledWord, string16 /* the word to update the panel with */) - // Initiate a download based on user actions like 'ALT+click'. + // Initiates a download based on user actions like 'ALT+click'. IPC_MESSAGE_ROUTED2(ViewHostMsg_DownloadUrl, GURL /* url */, GURL /* referrer */) @@ -1136,9 +1133,12 @@ IPC_BEGIN_MESSAGES(ViewHost) bool /* out - success */, std::wstring /* out - prompt field */) - // Sets the contents for the given page (URL and page ID are the first two - // arguments) given the contents that is the 3rd. - IPC_MESSAGE_CONTROL3(ViewHostMsg_PageContents, GURL, int32, std::wstring) + // Provides the contents for the given page that was loaded recently. + IPC_MESSAGE_ROUTED4(ViewHostMsg_PageContents, + GURL /* URL of the page */, + int32 /* page id */, + std::wstring /* page contents */, + std::string /* page ISO639_1 language code */) // Used to get the extension message bundle. IPC_SYNC_MESSAGE_CONTROL1_1(ViewHostMsg_GetExtensionMessageBundle, @@ -1167,13 +1167,13 @@ IPC_BEGIN_MESSAGES(ViewHost) // user right clicked. IPC_MESSAGE_ROUTED1(ViewHostMsg_ContextMenu, ContextMenuParams) - // Request that the given URL be opened in the specified manner. + // Requests that the given URL be opened in the specified manner. IPC_MESSAGE_ROUTED3(ViewHostMsg_OpenURL, GURL /* url */, GURL /* referrer */, WindowOpenDisposition /* disposition */) - // Notify that the preferred size of the content changed. + // Notifies that the preferred size of the content changed. IPC_MESSAGE_ROUTED1(ViewHostMsg_DidContentsPreferredSizeChange, gfx::Size /* pref_size */) |