diff options
| author | hclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-18 17:46:31 +0000 |
|---|---|---|
| committer | hclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-18 17:46:31 +0000 |
| commit | b0af04c4b7595afcfcfe847e232bc6ae88101735 (patch) | |
| tree | 9218ad9ed34635f3387dbbe7aca25a55e851e690 /chrome/common/resource_dispatcher.h | |
| parent | f4c6499a37788cd2bc2c4781f005ad2c03fd47e7 (diff) | |
| download | chromium_src-b0af04c4b7595afcfcfe847e232bc6ae88101735.zip chromium_src-b0af04c4b7595afcfcfe847e232bc6ae88101735.tar.gz chromium_src-b0af04c4b7595afcfcfe847e232bc6ae88101735.tar.bz2 | |
Fix a memory leak in ResourceDispatcher
When we delete a ResourceLoaderBridge before OnCompletedRequest is received, bad things happen. There's a lot of leaks at the following points:
1. OnMessageReceived ignores the message.
2. RemovePendingRequest removes it's internal deferred_message_queue.
But ViewHostMsg_Resource_DataReceived is not POD. We should also close the shared memory handle inside it.
Review URL: http://codereview.chromium.org/115396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16297 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/resource_dispatcher.h')
| -rw-r--r-- | chrome/common/resource_dispatcher.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/common/resource_dispatcher.h b/chrome/common/resource_dispatcher.h index 8ad20fe..f4494a5 100644 --- a/chrome/common/resource_dispatcher.h +++ b/chrome/common/resource_dispatcher.h @@ -114,6 +114,12 @@ class ResourceDispatcher { // Returns true if the message passed in is a resource related message. static bool IsResourceDispatcherMessage(const IPC::Message& message); + // ViewHostMsg_Resource_DataReceived is not POD, it has a shared memory + // handle in it that we should cleanup it up nicely. This method accepts any + // message and determine whether the message is + // ViewHostMsg_Resource_DataReceived and clean up the shared memory handle. + void ReleaseResourcesInDataMessage(const IPC::Message& message); + IPC::Message::Sender* message_sender_; // All pending requests issued to the host |