summaryrefslogtreecommitdiffstats
path: root/chrome/common/thumbnail_score.h
diff options
context:
space:
mode:
authorsatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-27 03:50:45 +0000
committersatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-27 03:50:45 +0000
commita8cb9b9fc197433e89c19e237ee7a76790451936 (patch)
treef58f7845db17ef843aedd5884df6d568760f43db /chrome/common/thumbnail_score.h
parent458592c9b33559dd3606be3e2904022b6b9abc66 (diff)
downloadchromium_src-a8cb9b9fc197433e89c19e237ee7a76790451936.zip
chromium_src-a8cb9b9fc197433e89c19e237ee7a76790451936.tar.gz
chromium_src-a8cb9b9fc197433e89c19e237ee7a76790451936.tar.bz2
Stop using the boring score for judging we should update a thumbnail or not.
The absolute boring score is not suitable for judging a thumbnail is actually boring or not. For instance, www.google.com is very succinct so the boring score can be as high as 0.9, where 1 is the maximum. This score should only be used for comparing two thumbnails taken from the same page to see which one is more boring/interesting. BUG=65936 TEST=with --enable-in-browser-thumbnailing --vmodule=thumbnail_generator=1, confirm that the thumbnail is not updated very often for www.google.com. Review URL: http://codereview.chromium.org/7071008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86965 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/thumbnail_score.h')
-rw-r--r--chrome/common/thumbnail_score.h7
1 files changed, 7 insertions, 0 deletions
diff --git a/chrome/common/thumbnail_score.h b/chrome/common/thumbnail_score.h
index 39fe0e2..d35d7d8 100644
--- a/chrome/common/thumbnail_score.h
+++ b/chrome/common/thumbnail_score.h
@@ -35,6 +35,13 @@ struct ThumbnailScore {
// percentage of pixels that are the most common luma. Higher boring
// scores indicate that a higher percentage of a bitmap are all the
// same brightness (most likely the same color).
+ //
+ // The score should only be used for comparing two thumbnails taken from
+ // the same page to see which one is more boring/interesting. The
+ // absolute score is not suitable for judging whether the thumbnail is
+ // actually boring or not. For instance, www.google.com is very
+ // succinct, so the boring score can be as high as 0.9, depending on the
+ // browser window size.
double boring_score;
// Whether the thumbnail was taken with height greater then