diff options
author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-28 20:29:40 +0000 |
---|---|---|
committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-28 20:29:40 +0000 |
commit | de86a8510c9c8f70f27ce41b425a82c416f987e2 (patch) | |
tree | b1442d4b7bd4a856c1389c908f7fd9298ec81270 /chrome/common/win_safe_util.cc | |
parent | fc7c36a2c51aeba1da2495ffa5f6944179b93974 (diff) | |
download | chromium_src-de86a8510c9c8f70f27ce41b425a82c416f987e2.zip chromium_src-de86a8510c9c8f70f27ce41b425a82c416f987e2.tar.gz chromium_src-de86a8510c9c8f70f27ce41b425a82c416f987e2.tar.bz2 |
Linux: call xdg-open on downloaded files to open them.
BUG=12299
TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download.
Review URL: http://codereview.chromium.org/112064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/win_safe_util.cc')
-rw-r--r-- | chrome/common/win_safe_util.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/chrome/common/win_safe_util.cc b/chrome/common/win_safe_util.cc index 2187d30..8afe8c5 100644 --- a/chrome/common/win_safe_util.cc +++ b/chrome/common/win_safe_util.cc @@ -23,8 +23,7 @@ namespace win_util { // http://msdn2.microsoft.com/en-us/library/ms647048.aspx bool SaferOpenItemViaShell(HWND hwnd, const std::wstring& window_title, const FilePath& full_path, - const std::wstring& source_url, - bool ask_for_app) { + const std::wstring& source_url) { ATL::CComPtr<IAttachmentExecute> attachment_services; HRESULT hr = attachment_services.CoCreateInstance(CLSID_AttachmentServices); if (FAILED(hr)) { @@ -34,7 +33,7 @@ bool SaferOpenItemViaShell(HWND hwnd, const std::wstring& window_title, NOTREACHED(); return false; } - return OpenItemViaShell(full_path, ask_for_app); + return OpenItemViaShell(full_path); } // This GUID is associated with any 'don't ask me again' settings that the @@ -92,7 +91,7 @@ bool SaferOpenItemViaShell(HWND hwnd, const std::wstring& window_title, return false; } } - return OpenItemViaShellNoZoneCheck(full_path, ask_for_app); + return OpenItemViaShellNoZoneCheck(full_path); } bool SetInternetZoneIdentifier(const FilePath& full_path) { |